Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Trait in favor of enum for SecretManager #407

Closed
Aconitin opened this issue May 8, 2023 · 0 comments · Fixed by #462
Closed

Use Trait in favor of enum for SecretManager #407

Aconitin opened this issue May 8, 2023 · 0 comments · Fixed by #462
Assignees
Labels
m-client Module - Client t-impl Task - Implementation
Milestone

Comments

@Aconitin
Copy link

Aconitin commented May 8, 2023

Description

(Copied over from Discord here )

We're trying to switch from Chrysalis to Shimmer (for our identity management product) and we're having an issue:

We would like to store our keys not in Stronghold but in a PKCS#11 compatible HSM. However, currently, all relevant APIs in iota_client require an instance of the SecretManager (https://github.com/iotaledger/iota-sdk/blob/develop/sdk/src/client/secret/mod.rs#L102) enum. None of the enums variants seem to fit our current usecase.

Motivation

Only allowing Stronghold or Ledger Nano as key storages doesn't really work for industry^^

Requirements

From our perspective, it would make sense to

Open questions (optional)

Any help/input would be much appreciated 🙂

Are you planning to do it yourself in a pull request?

Maybe?

@thibault-martinez thibault-martinez added this to the v1.0.0 milestone May 12, 2023
@thibault-martinez thibault-martinez added m-client Module - Client t-impl Task - Implementation labels May 15, 2023
DeppLearning pushed a commit to DeppLearning/iota-sdk that referenced this issue Jun 1, 2023
This is a temporary workaround until iotaledger#462 lands and iotaledger#407 is fully solved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
m-client Module - Client t-impl Task - Implementation
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants