Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve mobile detection and fix styles #119

Merged
merged 5 commits into from
May 16, 2024

Conversation

VmMad
Copy link
Member

@VmMad VmMad commented May 10, 2024

Fixes #118
Fixes #117

@VmMad VmMad marked this pull request as ready for review May 10, 2024 16:20
@VmMad VmMad requested review from evavirseda and removed request for evavirseda May 10, 2024 16:21
@VmMad VmMad marked this pull request as draft May 13, 2024 11:00
@VmMad VmMad marked this pull request as ready for review May 13, 2024 14:38
* refactor: mobile detection and tailwind constants

* refactor: improve code quality

* feat: add screenBreakpoint store and make isMobile a derived

---------

Co-authored-by: JCNoguera <jcnoguera@boxfish.studio>
Copy link

This pull request has been deployed to Vercel.

Latest commit: 5f97751
✅ Preview: https://iota-ui-r40tkbgzq-iota1.vercel.app
🔍 Inspect: https://vercel.com/iota/iota-ui-kit/AHBg5oztfvLcG8ELTL9WPLkJzjEn

View Workflow Logs

@VmMad VmMad changed the title feat: use svelte helpers to detect better mobile devices feat: improve mobile detection and fix styles May 13, 2024
@begonaalvarezd begonaalvarezd merged commit 10e2bf3 into main May 16, 2024
2 checks passed
@begonaalvarezd begonaalvarezd deleted the styles/fix-ios-styles branch May 16, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task]: Improve styles for iOS [Task]: Fix Hero variant primary alignment
3 participants