Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISC - Update network info - Requested updates #1561

Merged
merged 37 commits into from
May 29, 2024
Merged

ISC - Update network info - Requested updates #1561

merged 37 commits into from
May 29, 2024

Conversation

lucas-tortora
Copy link
Collaborator

@lucas-tortora lucas-tortora commented May 16, 2024 •
edited by Dr-Electron
Loading

Description of change

  • added Blast API info to networks-endpoints.mdx
  • fixed additional info header in networks-endpoints.mdx
  • added subgraphs.md article with link to blastApi
  • added blastAPI.md article
  • added iota_evm_dm.svg as icon @todo replace
  • added announcement bar about IOTA EVM
  • altered HomeLayout/index.tsx to add more focus to IOTA EVM
  • made table headers vertical instead of horizontal in NetworkInfo/index.tsx
  • removed unused import in networks-endpoints.mdx

Should be merged after #1541

Todo

  • Update IOTA EVM thumbnail icon
  • Update Oracles example to use IOTA EVM contractAddress, feedIds
  • Add Supra code examples to Oracles (@trungtt198x ? )
  • Update the style of the first EVM button on the homepage

Links to any relevant issues

fixes https://github.com/iotaledger/devx/issues/402
fixes #1554

Type of change

  • Documentation Enhancement

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own changes
  • I have made sure that added/changed links still work
  • I have commented my code, particularly in hard-to-understand areas

lucas-tortora and others added 16 commits April 1, 2024 09:52
@lucas-tortora
added IOTA EVM to networks-endpoints.mdx
4da7c08 
added IOTA EVM explorer and toolkit to getting-started/sidebars.ts
renamed ShimmerEVM testnet to EVM testnet
added IOTA EVM to NetworkInfo/index.tsx
added IOTA EVM to NetworkInfo/types.d.ts
added IOTA EVM to getting-started/compatibility.md
added IOTA EVM to isc/getting-started/networks-and-chains.mdx
added IOTA EVM to send-funds-from-L1-to-L2.mdx
added IOTA EVM to isc/getting-started/tools.mdx
added IOTA EVM to how-tos
@lucas-tortora
remove networks warning
2879e0b
@lucas-tortora
changed Public Testnet To EVM Testnet
a3c0e1e
@lucas-tortora
changed IOTA EVM to IotaEVM
c23cfcc
@lucas-tortora
changed IOTA EVM to IotaEVM
2df12ee
@Dr-Electron
Merge branch 'main' into ISC/updateNetworkInfo
19834cc
@Dr-Electron
Update network info
e234ba9
@Dr-Electron
Fix info
dda80d2
@Dr-Electron
Fix links
6966983
@Dr-Electron
Merge branch 'main' into ISC/updateNetworkInfo
eaddd60
@Dr-Electron
Format
172a25d
@Dr-Electron
Merge branch 'main' into ISC/updateNetworkInfo
c5df220
@Dr-Electron
Update sidebar
de27bbc
@Dr-Electron
Format
dc5e599
@lucas-tortora
made oracles page IOTA centric
e3e795f 
Inverted pyth and supra order
added tabs to code examples
@lucas-tortora
added Blast API info to networks-endpoints.mdx
5509a5f 
fixed additional info header in networks-endpoints.mdx
added subgraphs.md article with link to blastApi
added blastAPI.md article
added iota_evm_dm.svg as icon @todo replace
added announcement bar about IOTA EVM
altered HomeLayout/index.tsx to add more focus to IOTA EVM
made table headers vertical instead of horizontal in NetworkInfo/index.tsx
removed unused import in networks-endpoints.mdx
@lucas-tortora lucas-tortora marked this pull request as draft May 16, 2024 17:17
@lucas-tortora lucas-tortora marked this pull request as ready for review May 16, 2024 17:17
@lucas-tortora lucas-tortora marked this pull request as draft May 16, 2024 17:17
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5509a5f

✅ Preview: https://iota-wiki-kd20yhm7l-iota1.vercel.app

@Phyloiota
Copy link
Collaborator

Phyloiota commented May 17, 2024 •
edited
Loading

I would suggest we update the sidebar section

I would recommend to either call the subheader "IOTA EVM" and "IOTA EVM Testnet"
Or to call the links/pages "IOTA EVM Explorer", "IOTA EVM Toolkit".

We should always make sure to clearly differentiate the EVM from the L1 and not call both "IOTA" IMHO, L1 is IOTA, L2 is IOTA EVM. Same goes for Shimmer and Shimmer EVM btw.
Uploading Screenshot 2024-05-17 at 09.12.58.png…

@Phyloiota
Copy link
Collaborator

The page about Blast API is great; we just should keep in mind that we may not want to make a page introduction for every one of our future RPC provider. As we have a premium package with Blast this still makes sense, but as the EVM grows we will likely get further RPC providers on board (some chains have 8-12 of these) so we may want to rething merging those into a single page later

@Phyloiota
Copy link
Collaborator

The Subgraph page should be updated to include a reference to Goldsky https://goldsky.com/products/subgraphs

And in a few days we will also have a dedicated partner page here https://docs.goldsky.com/chains/supported-networks which we then could link

@Phyloiota
Copy link
Collaborator

You can also add the dedicated Endpoints from Blast API for IOTA EVM and EVM Testnet to networks and endpoints (and maybe the Blast API article):

EVM Mainnet:
RPC: https://iota-mainnet-evm.public.blastapi.io
WSS: wss://iota-mainnet-evm.public.blastapi.io
Archive RPC: https://iota-mainnet-evm.blastapi.io/e7596858-fc63-4a54-8727-b885a2af4ec8

EVM Testnet:
RPC: https://iota-testnet-evm.public.blastapi.io
WSS: wss://iota-testnet-evm.public.blastapi.io
Archive RPC: https://iota-testnet-evm.blastapi.io/e7596858-fc63-4a54-8727-b885a2af4ec8

@Phyloiota
Copy link
Collaborator

What i am missing now in this version is the MultiSig Wallet section - where do we have that linked?

@lucas-tortora
Copy link
Collaborator Author

What i am missing now in this version is the MultiSig Wallet section - where do we have that linked?

That's in another PR: #1537

@lucas-tortora
Added Goldsky to the subgraphs article
717c8c9 
Updated iota_evm.svg
Added all blast api endpoints to networks and endpoints
@Phyloiota
Copy link
Collaborator

Looks good now!

@lucas-tortora lucas-tortora mentioned this pull request May 22, 2024
Merged
3 tasks
Phyloiota
Phyloiota approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@Phyloiota Phyloiota left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice job

Base automatically changed from ISC/updateNetworkInfo to isc-update May 27, 2024 13:49
@Dr-Electron Dr-Electron marked this pull request as ready for review May 27, 2024 16:22
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d067fcb

✅ Preview: https://iota-wiki-gsutx6v08-iota1.vercel.app

lucas-tortora and others added 2 commits May 27, 2024 19:29
@lucas-tortora @Dr-Electron
Apply suggestions from code review
5188d7a 
Co-authored-by: Dr-Electron <dr-electr0n@protonmail.com>
@lucas-tortora
addressing comments from @Dr-Electron
f07006c
@Dr-Electron Dr-Electron merged commit 5b167fa into isc-update May 29, 2024
@Dr-Electron Dr-Electron deleted the ISC/updateNetworkInfoRequestedUpdates branch May 29, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Phyloiota Phyloiota Phyloiota approved these changes

@Dr-Electron Dr-Electron Dr-Electron approved these changes

@jlvandenhout jlvandenhout Awaiting requested review from jlvandenhout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lucas-tortora @Phyloiota @Dr-Electron