Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Kerl instead of Curl #6

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions curl.go
Original file line number Diff line number Diff line change
Expand Up @@ -107,10 +107,3 @@ func (c *Curl) Reset() {
c.state[i] = 0
}
}

//Hash returns hash of t.
func (t Trytes) Hash() Trytes {
c := NewCurl()
c.Absorb(t)
return c.Squeeze()
}
2 changes: 1 addition & 1 deletion curl_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ import "testing"
func TestCurl(t *testing.T) {
trytes := Trytes("QQ9VLGQTJICJH9UZNSBXRSKBWVXCTRNGLJPEYFSZBISDCGBHGAV9TEHIMJS9LMQNHFNWVAXALKGESPWZMUMZPQCKCUFSEJZVHWZHZOEZBPTERXPHUQLQLZMENKOKAWMJ9LCFSIBSBEYCJQVQQMTMRJMDEKRXLCIRZFWQBRJYLPSK9XLWFYFTU9FBJATWPQRJBHWYJRUEXSXMBJLVWNYRTZJTHLEKDTWCGJ9OXDEZNWTKLTXXTKVFXDMRJUDAMDACRHJKZIJFJBZRVDLSTIMOWPTLLIVHCFUBMSQIPVPCSQAPZGHHNNQLWEHDTIQZQTAXJMTTROYOTIZSZKKQFXBHXFKSNAGZWHWEGXCKHSJQGBJGC9IKUSSJEAOHTPGPMIYPEXJXJKRLX9IOCUDKK9ONEUONYVGHRHXSAUZJXGVQNWSDZIYXXZMMJKRTOXSWJHBIMXPEMJTKIBSQKPICTKAQLJVOLZSGNVVBIOFJJKKJ9UBYKJWCBRPQLGBNEKEFRYCHB9PORAKEKTJZYZBFGZLONUJCPNINGUTYWTMDKTEPDASCHNVHXTUIOZ9PDALXKQYLILMUJEJWTYYAGEQXNNPLOMFGHSTFCNRMDFUSQREHFASDXZZOYNWNVKCRFZIDF9X9YKME9O9NJH9LFVNNSOXHSQOMBULFHBBPSGRCCGKWENQOZHRSIIHKKXAQTFISNVGIVMBDKSJYDW9VTZBAVYWWJAIYSCHGBIXKMKHBRTHWQMIWQVPWFUJQVUDZRDX9MMCXOQTQZGKECGIHATHUC9TDGKUKOYXEEBGTQYEO9KADOSMYWGQARTIUG9IUHQEBWSFHWDZCRCH9WDRJEUSQDBBGGKTOYBKYZX9LUKUGBVTEPXDOVVNSKPUWNARSILQNOQKATCUHMRVMKVHF9B9TEJDOMBDXLNKDJI9IIYRXNOQPBOVOEEGQFSZJJOFPNFVXOYZNLSOOA9FWDFJKDOQUHWHBNDWQZZVRBZJSLDVBRCGFCWXNUFTMLCHNXODSQMUIBPN9NMAXZXKUYYRUEDSLW9UEQYGSEBEOHGI9W9WAUFDEQCXVYOTBAAHFXHRGJBWGFZKIUMSWEXAD9EDALOOYQZIXKUOWJDHBHSEUDPJJRXANPPHUZWJM9KDVGJUAQHFJTWNFSULGSWMGMAOCAHTIYYJONOLKGNKRXWWZYWKITSFPQJNHQWAIJULYWPXQENPZTWZISXJBWYLENOINLFBRWWGWSWJONHIA99VGCSAT9XNMZUCSVEJMZJASUSXVUWFSVFXUIFWGIFKLEFLANHTITFCOPXRXTDXRDHLWP9RJHVQJMLPBFVHTIOQMSZECNPITTBTPLUHDQQZP9BWTWIZSOTMTZQWHCETRTKQPOHPJMJMLSBWC9ZRQAZDLAPJHAXRQZ9RUHHBPASWVUHBYX9FH9PLEHQEKCOMIHUNDVKOPKXEFM9CNP9LOLMBVHMMWNDCKHSYZEXOJAQOHMRXEGWMWFW9YVOZ9YDPHWVTKWFYUECSROYJENFPSIKHBJRSNWO9KQUENGPVULVYAQFAIYFSNIYR9LLRMYNCNQQAOPFNMWFSWSPMWNNIRNVKDZWRLGMPCBOVIMMXEZUFYPFPIGWTGOLDAEBZQADSOGVDZXHEWZGHNAAHMFPSOZD9SEPNCW9GTN9WLFDDCKMMXPXAEUUJPJFKKWMGUKVMYBH9AIEFAIIDJOAWRDKECA99XOYRSFZQKTVRJMTUAQJZUTKGXROESUYYSHTLRIZRPSNDFEEZWXCQONZYCD9TOHCBP9ISXQ9YSRZJ999Z9TETYOINSDGRBQSDTVFABHQNLTWGFYLHBHPVKLIBUMLVSURAOS9QHXDTIPKOJDLYOKRCEKCBMKVYIAKVA9WTGDWHIRUAWOVRKOSYTNIZAZNTJRFJDMNLGHTDKPKZDLBPQXRIRIVREMOBCPHMBBAUKNXHU9XIZNG9GD9LDIBBFPSI9PJNRCHXHNWAZXIACE9LUBNUWOK9LGJ9MKZQRI9CBCJUNALQKKVGGSPRJFAGCXNFO99YMLMKI9NVUZCZ9BCUEBSGMAVNKGWYWWQPZISMKAROXLQWEHOJIJOIIYRUDBNHRD9DEDQWQONAXKKSYMYCFTITZFKIXKZCGAVAFQIYEMESOIMWUUDSXJRR9RVWTAAHCOA9SCQBF9LAGPPYDXPEBKLHZ9KHKTXFP9XOVMVWIXEWMOISJHMQEXMYMZCUGEQNKGUNVRPUDPRX9IR9LBASIARWNFXXESPITSLYAQMLCLVTLHW9999999999999999999999999999999999999999999999999999FBIEUWD99A99999999C99999999DEXRPLKGBROUQMKCLMRPG9HFKCACDZ9AB9HOJQWERTYWERJNOYLW9PKLOGDUPC9DLGSUH9UHSKJOASJRU9MMRRSLICRITOROFC9FBVWLFEDNN9KJKYHUMRCJEUDGCYCWTBP9HHBEEJRFAU9FALRJWTU99NZK999999UE9VSBDVSRNTBZWPXYZPGAUTSWFLARLPXMHYBSTEUWIDOFJQJMVIACGUPTOMBWQO9AEADCFCMFJ999999WQKHJEXIHMOKQETOUTEO9JUPCDNAJQYZVXQRCXGYGEBOTMHE9HSJXVYVQUS9FPDLQWWKSYVDPCXX9LLAT")
hh := Trytes("MRYSIXABICSX9XQSLPAPQHGAPCMBDQZXH9EOHPLL9LFQNUDTETNQFUJO9DPHTNPJI9BTQH9RM9I999999")
h := trytes.Hash()
h := trytes.CurlHash()
if hh != h {
t.Error("hash is illegal.")
}
Expand Down
2 changes: 1 addition & 1 deletion pow_c_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func testPowC(t *testing.T) {
t.Fatal(err)
}
tx = tx[:len(tx)-NonceTrinarySize/3] + nonce
h := tx.Hash()
h := tx.CurlHash()
if h[len(h)-5:] != "99999" {
t.Error("pow is illegal", h)
}
Expand Down
2 changes: 1 addition & 1 deletion pow_go_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ func testPowGo(t *testing.T) {
t.Fatal(err)
}
tx = tx[:len(tx)-NonceTrinarySize/3] + nonce
h := tx.Hash()
h := tx.CurlHash()
if h[len(h)-5:] != "99999" {
t.Error("pow is illegal", h)
}
Expand Down
67 changes: 46 additions & 21 deletions sign.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ package giota
import (
"crypto/rand"
"errors"
"math"
"math/big"
)

Expand Down Expand Up @@ -81,14 +82,14 @@ func NewKey(seed Trytes, index, securityLevel int) Trytes {
seed = seedTrits.Trytes()
hash := seed.Hash()

c := NewCurl()
c.Absorb(hash)
k := NewKerl()
k.Absorb(hash.Trits())

key := make([]byte, (HashSize*27*securityLevel)/3)
for l := 0; l < securityLevel; l++ {
for i := 0; i < 27; i++ {
b := c.Squeeze()
copy(key[(l*27+i)*HashSize/3:], b)
b, _ := k.Squeeze(HashSize)
copy(key[(l*27+i)*HashSize/3:], []byte(b.Trytes()))
}
}

Expand Down Expand Up @@ -152,26 +153,39 @@ func seri27(l *[stateSize]uint64, h *[stateSize]uint64) Trytes {
return keyFragment.Trytes()
}

//Digests calculates hash x 26 for each segments in keyTrits.
func Digests(key Trytes) (Trytes, error) {
if len(key) < HashSize*27/3 {
return "", ErrKeyTritsLength
}
//var digests Trits
var buffer Trits
k := key.Trits()
digests := make(Trits, int(math.Floor(float64(len(k))/float64(SignatureSize)))*HashSize)
for i := 0; i < int(math.Floor(float64(len(k))/float64(SignatureSize))); i++ {
keyFragment := k[i*SignatureSize : (i+1)*SignatureSize]
for j := 0; j < 27; j++ {
buffer = keyFragment[j*HashSize : (j+1)*HashSize]
for k := 0; k < MaxTryteValue-MinTryteValue; k++ {
kKerl := NewKerl()
kKerl.Reset()
kKerl.Absorb(buffer)
buffer, _ = kKerl.Squeeze(HashSize)
}
for k := 0; k < HashSize; k++ {
t := keyFragment
t[j*HashSize+k] = buffer[k]
keyFragment = t
}
}

// Integer division, becaue we don't care about impartial keys.
numKeys := len(key) / (HashSize * 9)
digests := make([]byte, HashSize*numKeys/3)
for i := 0; i < numKeys; i++ {
lmid, hmid := para27(key[i*HashSize*9:])
for k := 0; k < 26; k++ {
transform64(lmid, hmid)
clearState(lmid, hmid)
var kerl = NewKerl()
kerl.Reset()
kerl.Absorb(keyFragment)
buffer, _ = kerl.Squeeze(HashSize)
for j := 0; j < HashSize; j++ {
t := digests
t[i*HashSize+j] = buffer[j]
digests = t
}
keyFragment := seri27(lmid, hmid)
s := keyFragment.Hash()
copy(digests[i*HashSize/3:], s)
}
return Trytes(digests), nil
return digests.Trytes(), nil
}

//digest calculates hash x normalizedBundleFragment[i] for each segments in keyTrits.
Expand Down Expand Up @@ -293,7 +307,18 @@ func (a Address) Checksum() Trytes {
if len(a) != 81 {
panic("len(address) must be 81")
}
return Trytes(a).Hash()[:9]

addressTrits := Trytes(a).Trits()

kerl := NewKerl()
kerl.Reset()
kerl.Absorb(addressTrits)
checksumTrits, _ := kerl.Squeeze(HashSize)

checksumTrytes := checksumTrits.Trytes()
checksum := checksumTrytes[len(checksumTrytes)-9:]

return checksum
}

//WithChecksum returns Address+checksum.
Expand Down
10 changes: 5 additions & 5 deletions sign_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ var addressTCs = []addressTestCase{
addressTestCase{
addr: "RGVOWCDJAGSO9TNLBBPUVYE9KHBOAZNVFRVKVYYCHRKQRKRNKGGWBF9WCRJVROKLVKWZUMBABVJGAALWU",
validAddr: true,
checksum: "QNXFPRSPG",
checksum: "NPJ9QIHFW",
validChecksum: true,
},
addressTestCase{
Expand All @@ -68,9 +68,9 @@ var addressTCs = []addressTestCase{
validChecksum: true,
},
addressTestCase{
addr: "999999999999999999999999999999999999999999999999999999999999999999999999999999999999999999",
addr: "999999999999999999999999999999999999999999999999999999999999999999999999999999999",
validAddr: true,
checksum: "999999999",
checksum: "A9BEONKZW",
validChecksum: true,
},
addressTestCase{
Expand Down Expand Up @@ -109,8 +109,8 @@ func TestNewAddressFromTrytes(t *testing.T) {

func TestAddress(t *testing.T) {
var seed Trytes = "WQNZOHUT99PWKEBFSKQSYNC9XHT9GEBMOSJAQDQAXPEZPJNDIUB9TSNWVMHKWICW9WVZXSMDFGISOD9FZ"
var adr0 Trytes = "KTXFP9XOVMVWIXEWMOISJHMQEXMYMZCUGEQNKGUNVRPUDPRX9IR9LBASIARWNFXXESPITSLYAQMLCLVTL9QTIWOWTY"
var adr1 Trytes = "PQTDJXXKSNYZGRJDXEHHMNCLUVOIRZC9VXYLSITYMVCQDQERAHAUZJKRNBQEUHOLEAXRUSQBNYVJWESYRPLAKVDWST"
var adr0 Trytes = "AYYNHWWNZQOFYXNQSLVULU9ARZCSXNWWAFYEWEL9LIXYDFS9KDSRZF9ZID9AQWSLAEUAJSTQKGPGXNWCDDSSQMTJOA"
var adr1 Trytes = "9CTFIAYOFLOKXVNDFKNERQQEFR9FCIXQQHNRDKHIVVGFZQKTBWPCOIHCCQIU9ASJQECGPHDBAREDXIRCXOZXPACEEW"
adr, err := NewAddress(seed, 0, 2)
if err != nil {
t.Fatal(err)
Expand Down
2 changes: 1 addition & 1 deletion transaction.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ func (t *Transaction) HasValidNonce(mwm int64) bool {

//Hash returns the hash of the transaction.
func (t *Transaction) Hash() Trytes {
return t.Trytes().Hash()
return t.Trytes().CurlHash()
}

//UnmarshalJSON makes transaction struct from json.
Expand Down
15 changes: 15 additions & 0 deletions trinary.go
Original file line number Diff line number Diff line change
Expand Up @@ -372,3 +372,18 @@ func (t Trytes) IsValid() error {
}
return nil
}

//Hash returns hash of t.
func (t Trytes) Hash() Trytes {
c := NewKerl()
c.Absorb(t.Trits())
tt, _ := c.Squeeze(HashSize)
return tt.Trytes()
}

//Hash returns hash of t.
func (t Trytes) CurlHash() Trytes {
c := NewCurl()
c.Absorb(t)
return c.Squeeze()
}