Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crypto-js in group default to the latest version 馃殌 #460

Merged
merged 7 commits into from Jun 16, 2020

Conversation

greenkeeper[bot]
Copy link
Contributor

@greenkeeper greenkeeper bot commented Feb 12, 2020

The dependency crypto-js was updated from 3.3.0 to 4.0.0.

This version is not covered by your current version range.

If you don鈥檛 accept this pull request, your project will work just like it did before. However, you might be missing out on a bunch of new features, fixes and/or performance improvements from the dependency update.


Publisher: evanvosberg
License: MIT

Find out more about this release.


FAQ and help

There is a collection of frequently asked questions. If those don鈥檛 help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper bot 馃尨

@laumair laumair self-requested a review April 22, 2020 13:18
@laumair laumair requested a review from rajivshah3 June 15, 2020 08:34
@laumair
Copy link
Contributor

laumair commented Jun 15, 2020

Some really basic manual tests that I did:

Commit 7c1b45b:

  • Address generation:
const Iota = require('@iota/core');

const iota = Iota.composeAPI({
    provider: 'https://node02.iotatoken.nl:443'
});

const seeds = [
    'EQSAUZXULTTYZCLNJNTXQTQHOMOFZERHTCGTXOLTVAHKSA9OGAZDEKECURBRIXIJWNPFCQIOVFVVXJVD9',
    'JURSJVFIECKJYEHPATCXADQGHABKOOEZCRUHLIDHPNPIGRCXBFBWVISWCF9ODWQKLXBKY9FACCKVXRAGZ',
    'LVATZG9RGPTGYQJJJNOXCMQPSWRUXCAWPTUYAOMCFM9VWOWZJUBIRBRRNETEEUWDZKEPOUAYKGTWUHHVW',
    'RCONCKUFMSHCPJDHBLMHGAIDNGBDNJWJSYKQTOWGDFXKBLKWWQAGMXDADCWDNBKNDEUQPMYDVUF9RMOKC',
    'U9DTHOFAJGNDKJVAUQPBJZME9OHQZBBECSYJNLKQWAJEIVCMUEDOCKPHTMNYEGVMEY9JGBWKHTPNAPP9B',
    'APEXNDMQHG9KHJUP9E9MPBZIHLKGRZYMS9OC9OEKDFRYKMZ9TQ9JPOVCFYBLOXW9PDMDMDZXSJMXBQVTZ'
]

seeds.forEach((seed) => {
    iota.getNewAddress(seed, {
        index: 0
    }).then((address) => {
        console.info(`Address for seed ${seed}: ${address}`);
    });
});

Output:

Address for seed LVATZG9RGPTGYQJJJNOXCMQPSWRUXCAWPTUYAOMCFM9VWOWZJUBIRBRRNETEEUWDZKEPOUAYKGTWUHHVW: VOPXEHGJKMWHRLCIYOGZDDWHMQBEVPKFTO9JUHEALPCBWUD9MAZONWAJJXF9GYQJAMTGPMUJHWMNMTFUY
Address for seed RCONCKUFMSHCPJDHBLMHGAIDNGBDNJWJSYKQTOWGDFXKBLKWWQAGMXDADCWDNBKNDEUQPMYDVUF9RMOKC: 9CAXUYYESDMSSSHLPYRKP9SD9FUGDAUUSQK9H9WDUFYJUJETETLWLEELHZ9CEKXIBZBKNMBHNCXTEDNMZ
Address for seed JURSJVFIECKJYEHPATCXADQGHABKOOEZCRUHLIDHPNPIGRCXBFBWVISWCF9ODWQKLXBKY9FACCKVXRAGZ: KZVGOETNHJDLNFNCNUMZJDBUBIENZPCBZWBPMJ9KKPXJKUYSUXWBFBBXJHKHQOBEPNMZHRMLUCJNRNVXW
Address for seed EQSAUZXULTTYZCLNJNTXQTQHOMOFZERHTCGTXOLTVAHKSA9OGAZDEKECURBRIXIJWNPFCQIOVFVVXJVD9: HIKMYADINYRMRMDG9ULPYBSQAINGKQDWNIFJVOOALPBARLIKQBYHIJPFZODKQRQGEVAZCQEISLKKFMGSC
Address for seed U9DTHOFAJGNDKJVAUQPBJZME9OHQZBBECSYJNLKQWAJEIVCMUEDOCKPHTMNYEGVMEY9JGBWKHTPNAPP9B: EK9DTNUYCPPYOTWXQRGXT9MJUAKS9EBQLYKAJLLGCUUQSDLA9XVXJGWTEVHPQNIGFAKDFTFHIVHDOLF9D
Address for seed APEXNDMQHG9KHJUP9E9MPBZIHLKGRZYMS9OC9OEKDFRYKMZ9TQ9JPOVCFYBLOXW9PDMDMDZXSJMXBQVTZ: CHDETGVKRLYNZGWKNLVHDVLZLXMYWSWLFORIOMPGQVD9ZAJCVVCIX99MMNSHIPLXHKR9POLDMEGUJYELX
  • Bundle construction and validation
const Iota = require('@iota/core');
const { asTransactionObject } = require('@iota/transaction-converter')
const isBundle = require('@iota/bundle-validator')

const iota = Iota.composeAPI({
    provider: 'https://node02.iotatoken.nl:443'
});

const seed = 'ABEFPZFVP9AFQMDIFRWEKZQFTWQKSKPJQMXSGEOWTPGJNNVRLNKKCEGCWFYBTFBZCNHHDJCEJJMVUUCSJ';

iota.prepareTransfers(
    seed,
    [{
        address: 'JNLJKFD9AZAWTTOFRAJLTGMPNKXZ9LSECVQYMFGSRBOCWNEUGXYEV9GENRTEFZQGFBOJUOARADIVDQZUC',
        value: 1,
    }]
).then((trytes) => {
    const txs = trytes.map(asTransactionObject);
    console.log('isBundle', isBundle.default(txs.reverse()));
}).catch(console.log);

Output:

isBundle true

Commit d42eb4a:

  • Address generation:

Outputs:

Address for seed APEXNDMQHG9KHJUP9E9MPBZIHLKGRZYMS9OC9OEKDFRYKMZ9TQ9JPOVCFYBLOXW9PDMDMDZXSJMXBQVTZ: CHDETGVKRLYNZGWKNLVHDVLZLXMYWSWLFORIOMPGQVD9ZAJCVVCIX99MMNSHIPLXHKR9POLDMEGUJYELX
Address for seed EQSAUZXULTTYZCLNJNTXQTQHOMOFZERHTCGTXOLTVAHKSA9OGAZDEKECURBRIXIJWNPFCQIOVFVVXJVD9: HIKMYADINYRMRMDG9ULPYBSQAINGKQDWNIFJVOOALPBARLIKQBYHIJPFZODKQRQGEVAZCQEISLKKFMGSC
Address for seed JURSJVFIECKJYEHPATCXADQGHABKOOEZCRUHLIDHPNPIGRCXBFBWVISWCF9ODWQKLXBKY9FACCKVXRAGZ: KZVGOETNHJDLNFNCNUMZJDBUBIENZPCBZWBPMJ9KKPXJKUYSUXWBFBBXJHKHQOBEPNMZHRMLUCJNRNVXW
Address for seed LVATZG9RGPTGYQJJJNOXCMQPSWRUXCAWPTUYAOMCFM9VWOWZJUBIRBRRNETEEUWDZKEPOUAYKGTWUHHVW: VOPXEHGJKMWHRLCIYOGZDDWHMQBEVPKFTO9JUHEALPCBWUD9MAZONWAJJXF9GYQJAMTGPMUJHWMNMTFUY
Address for seed U9DTHOFAJGNDKJVAUQPBJZME9OHQZBBECSYJNLKQWAJEIVCMUEDOCKPHTMNYEGVMEY9JGBWKHTPNAPP9B: EK9DTNUYCPPYOTWXQRGXT9MJUAKS9EBQLYKAJLLGCUUQSDLA9XVXJGWTEVHPQNIGFAKDFTFHIVHDOLF9D
Address for seed RCONCKUFMSHCPJDHBLMHGAIDNGBDNJWJSYKQTOWGDFXKBLKWWQAGMXDADCWDNBKNDEUQPMYDVUF9RMOKC: 9CAXUYYESDMSSSHLPYRKP9SD9FUGDAUUSQK9H9WDUFYJUJETETLWLEELHZ9CEKXIBZBKNMBHNCXTEDNMZ
  • Bundle construction and validation

Output:

isBundle true

rajivshah3
rajivshah3 previously approved these changes Jun 15, 2020
@rajivshah3
Copy link
Member

Should we also update @types/crypto-js to 3.1.47?

@laumair
Copy link
Contributor

laumair commented Jun 15, 2020

Should we also update @types/crypto-js to 3.1.47?

Yep, good idea @rajivshah3

@laumair laumair merged commit ea3da74 into next Jun 16, 2020
@laumair laumair deleted the greenkeeper/default/crypto-js-4.0.0 branch June 16, 2020 10:56
@laumair laumair mentioned this pull request Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants