Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Updates for compatibility with IRI 1.4.1 #84

Closed
todofixthis opened this issue Oct 24, 2017 · 3 comments
Closed

Updates for compatibility with IRI 1.4.1 #84

todofixthis opened this issue Oct 24, 2017 · 3 comments
Assignees
Labels

Comments

@todofixthis
Copy link
Contributor

todofixthis commented Oct 24, 2017

IRI v1.4.1 was released yesterday, and all API libraries need some changes to be compatible:

@todofixthis todofixthis self-assigned this Oct 24, 2017
@lacicloud
Copy link

lacicloud commented Oct 26, 2017

Temporary fix for those who are looking is to edit the file https://github.com/iotaledger/iota.lib.py/blob/master/iota/adapter/__init__.py : after line 268, add
kwargs['headers']['X-IOTA-API-Version'] = 'ANY'
*Where ANY can be whatever you want

Keep up the good work @todofixthis !

@todofixthis
Copy link
Contributor Author

todofixthis commented Oct 27, 2017

I believe we can use this as a test case for the insecure bundle detection:

> var b = new Bundle();
> b.addEntry(1, '9XV9RJGFJJZWITDPKSQXRTHCKJAIZZY9BYLBEQUXUNCLITRQDR9CCD99AANMXYEKD9GLJGVB9HIAGRIBQ', 0, 'PPDIDNQDJZGUQKOWJ9JZRCKOVGP', 1509136296, 0)
undefined
> b.finalize()
undefined
> b.bundle[0]
{ address: '9XV9RJGFJJZWITDPKSQXRTHCKJAIZZY9BYLBEQUXUNCLITRQDR9CCD99AANMXYEKD9GLJGVB9HIAGRIBQ',
  value: 0,
  obsoleteTag: 'ZTDIDNQDJZGUQKOWJ9JZRCKOVGP',
  tag: 'PPDIDNQDJZGUQKOWJ9JZRCKOVGP',
  timestamp: 1509136296,
  currentIndex: 0,
  lastIndex: 0,
  bundle: 'NYSJSEGCWESDAFLIFCNJFWGZ9PCYDOT9VCSALKBD9UUNKBJAJCB9KVMTHZDPRDDXC9UFJQBJBQFUPJKFC' }

Note that after finalising, the obsoleteTag value is different than what was provided to addEntry.

Checking with core devs just to make sure I'm on the right track.

todofixthis added a commit that referenced this issue Oct 27, 2017
todofixthis added a commit that referenced this issue Oct 28, 2017
Note: `PrepareTransferCommand` tests still need to be refactored.
This was referenced Oct 28, 2017
@todofixthis
Copy link
Contributor Author

Scheduled for release: 2.0.1

marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
Note: `PrepareTransferCommand` tests still need to be refactored.
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants