Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Refactor copy-pasted securityLevel filters #176

Closed
todofixthis opened this issue Apr 18, 2018 · 1 comment
Closed

Refactor copy-pasted securityLevel filters #176

todofixthis opened this issue Apr 18, 2018 · 1 comment
Labels
enhancement help wanted

Comments

@todofixthis
Copy link
Contributor

There's a lot of copy-pasted code for validating securityLevel in certain command filters:

'securityLevel': f.Type(int) | f.Min(1) | f.Max(3) | f.Optional(default=AddressGenerator.DEFAULT_SECURITY_LEVEL),

We could convert this into a filter macro in iota/filters.py to ensure consistency. As a bonus, we could also remove a bunch of duplicate unit tests.
@todofixthis todofixthis added this to Backlog in PyOTA via automation Apr 18, 2018
@todofixthis todofixthis moved this from Backlog to In Progress in PyOTA Jun 8, 2018
todofixthis added a commit that referenced this issue Jun 8, 2018
@todofixthis
[#176] Added SecurityLevel filter macro.
edbebf4
@todofixthis todofixthis mentioned this issue Jun 8, 2018
Merged
todofixthis added a commit that referenced this issue Jun 8, 2018
@todofixthis
Merge pull request #182 from iotaledger/feature/176-security-level-fi…
0b92f6b 
…lter

[#176] Added `SecurityLevel` filter macro.
@todofixthis todofixthis moved this from In Progress to Done 2.0.6 in PyOTA Jun 9, 2018
@todofixthis
Copy link
Contributor Author

Scheduled for release: 2.0.6

@todofixthis todofixthis mentioned this issue Jun 9, 2018
Merged
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
@todofixthis
[iotaledger#176] Added SecurityLevel filter macro.
2fbcf48
marko-k0 pushed a commit to marko-k0/iota.lib.py that referenced this issue Jul 28, 2018
@todofixthis
Merge pull request iotaledger#182 from iotaledger/feature/176-securit…
d6536e8 
…y-level-filter

[iotaledger#176] Added `SecurityLevel` filter macro.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@todofixthis