Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong assumption that sec-levels above 3 is invalid #129

Closed
frohal opened this issue Aug 31, 2020 · 2 comments
Closed

Wrong assumption that sec-levels above 3 is invalid #129

frohal opened this issue Aug 31, 2020 · 2 comments

Comments

@frohal
Copy link

frohal commented Aug 31, 2020

I looked at the client-code, and at the getNewAddress-function and discovered a flaw compared to how the protocol has worked earlier.
There has never been any problems using security-levels above 3, they just don't gine any added security, but an address generated with securitylevel 4 or 5 would just need as many tx'es to publish the signature, and all parts of it would then be used to verify the signature.

At least this worked with IRI, and there has not been any mentions about changes in support for sec-levels above 3
samplebundle is KWCSPUKCALYCDPRGDWEVSU9HRIJWUDCXJCDYPCZZJSBDY9SYR9H9X99QWUHPLDDY9UVSBWAKHAZFKSCCC
just sendt and verified by hornet-nodes from an address created with sec-level 5 (using the old java-libs)

@wusyong
Copy link
Contributor

wusyong commented Sep 2, 2020

Thanks for notifying. The signing crate is designed in the way that users can sign as documentation suggests. We are going to shift to new transaction layout which might have a slightly different signing scheme on WOTS. Wolfgang will draft another RFC about this in near future. I will address this issue in the RFC and maybe you can also follow it.

@frohal
Copy link
Author

frohal commented Sep 3, 2020

Since the 'public' libs for some time already has denied users to create addresses outside 1-3-levels, this is probably not an issie. You are free to choose the restrictions on the libs you create, but I assume that the validity-checking of signatures in the new format will validate signatures that are of any length - since they should also support multisig-transactions, and during validation- there are no difference between a multisg-address created on seclevel 3 by 3 wallets and one seclevel9-address created by my client-lib.
So it's then perfectly OK for your lib to restrict the users of this to only use levels 1-3.

@frohal frohal closed this as completed Sep 3, 2020
cycraig pushed a commit to cycraig/iota.rs-wasm that referenced this issue Aug 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants