This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
add 'coordinatorAddress' to 'getNodeInfo' response. #1103
Merged
GalRogozinski
merged 3 commits into
iotaledger:dev
from
alon-e:feat/getNodeInfoAddCooAddress
Nov 6, 2018
Merged
add 'coordinatorAddress' to 'getNodeInfo' response. #1103
GalRogozinski
merged 3 commits into
iotaledger:dev
from
alon-e:feat/getNodeInfoAddCooAddress
Nov 6, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alon-e
commented
Oct 31, 2018
|
||
public static AbstractResponse create(String appName, String appVersion, int jreAvailableProcessors, long jreFreeMemory, | ||
String jreVersion, long maxMemory, long totalMemory, Hash latestMilestone, int latestMilestoneIndex, | ||
Hash latestSolidSubtangleMilestone, int latestSolidSubtangleMilestoneIndex, int milestoneStartIndex, | ||
int neighbors, int packetsQueueSize, | ||
long currentTimeMillis, int tips, int numberOfTransactionsToRequest) { | ||
long currentTimeMillis, int tips, int numberOfTransactionsToRequest, | ||
String coordinatorAddress) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the style guide speaking... I will align it back -- this file uses tabs :/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you also change the regression test in api_tests.feature
in a seperate commit?
alon-e
force-pushed
the
feat/getNodeInfoAddCooAddress
branch
from
November 5, 2018 15:12
f2ca51b
to
c703ef7
Compare
Added. |
GalRogozinski
suggested changes
Nov 5, 2018
@@ -38,6 +38,7 @@ Feature: Test API calls on Machine 1 | |||
|time | | |||
|tips | | |||
|transactionsToRequest | | |||
|coordinatorAddress | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you just fix the indentation so that |
will be on a single column?
GalRogozinski
approved these changes
Nov 6, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
adds 'coordinatorAddress' to 'getNodeInfo' response:
Fixes #1056
Type of change
How Has This Been Tested?
Checklist:
Please delete items that are not relevant.