Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

add 'coordinatorAddress' to 'getNodeInfo' response. #1103

Merged
merged 3 commits into from Nov 6, 2018

Conversation

alon-e
Copy link
Contributor

@alon-e alon-e commented Oct 31, 2018

Description

adds 'coordinatorAddress' to 'getNodeInfo' response:

curl localhost:14265 \
  -X POST \
  -H 'Content-Type: application/json' \
  -H 'X-IOTA-API-Version: 1' \
  -d '{"command": "getNodeInfo"}' | jq
{
  "appName": "IRI Testnet",
  "appVersion": "1.5.5",
  "jreAvailableProcessors": 4,
...
  "coordinatorAddress": "HQUUXGMQOVHJFJPOELGYJ9EJYSCLQDGH9F9VYYQAJPR9DRYEYPBFWXTHEVHRMKGHRKJYXIQOLRVOLSXJJ",
  "duration": 21
}

Fixes #1056

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • locally running a node
  • changing Coo address and rerunning tests.

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@alon-e alon-e added the C-API Component - API label Oct 31, 2018

public static AbstractResponse create(String appName, String appVersion, int jreAvailableProcessors, long jreFreeMemory,
String jreVersion, long maxMemory, long totalMemory, Hash latestMilestone, int latestMilestoneIndex,
Hash latestSolidSubtangleMilestone, int latestSolidSubtangleMilestoneIndex, int milestoneStartIndex,
int neighbors, int packetsQueueSize,
long currentTimeMillis, int tips, int numberOfTransactionsToRequest) {
long currentTimeMillis, int tips, int numberOfTransactionsToRequest,
String coordinatorAddress) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is the style guide speaking... I will align it back -- this file uses tabs :/

Copy link
Contributor

@GalRogozinski GalRogozinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also change the regression test in api_tests.feature in a seperate commit?

@alon-e alon-e force-pushed the feat/getNodeInfoAddCooAddress branch from f2ca51b to c703ef7 Compare November 5, 2018 15:12
@alon-e
Copy link
Contributor Author

alon-e commented Nov 5, 2018

Can you also change the regression test in api_tests.feature in a seperate commit?

Added.

@@ -38,6 +38,7 @@ Feature: Test API calls on Machine 1
|time |
|tips |
|transactionsToRequest |
|coordinatorAddress |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you just fix the indentation so that | will be on a single column?

@GalRogozinski GalRogozinski merged commit 867d8ed into iotaledger:dev Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C-API Component - API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Coo address to getNodeInfo API response
2 participants