Skip to content
This repository has been archived by the owner on Aug 23, 2020. It is now read-only.

Prepare IRI to have its version injected by CI #1359

Merged
merged 8 commits into from Mar 13, 2019

Conversation

GalRogozinski
Copy link
Contributor

Description

  1. One source of truth for version in POM
  2. Changes local mvn clean package runs to output jar versions in the form `X.X.X-DEV-{git_hash_abbrev}.
  3. Official builts by the CI will have another version.
  4. The version is now also added to the jar manifest.
  5. When running from IDE version is parsed exactly as it is in POM

Fixes #1220

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  1. maven was ran locally
  2. IRI was run locally
  3. Travis passed

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes

@GalRogozinski
Copy link
Contributor Author

This cannot be merged until we finalize versioning in the CI !!

@iotaledger iotaledger deleted a comment Feb 26, 2019
@iotaledger iotaledger deleted a comment Feb 26, 2019
@iotaledger iotaledger deleted a comment Feb 26, 2019
@iotaledger iotaledger deleted a comment from GalRogozinski Feb 26, 2019
@iotaledger iotaledger deleted a comment Feb 26, 2019
@GalRogozinski GalRogozinski merged commit d4f2a50 into iotaledger:dev Mar 13, 2019
@jakubcech jakubcech mentioned this pull request May 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants