Change: Made API class easier to work with #1374
Conversation
| @@ -1,6 +1,6 @@ | |||
| package com.iota.iri.service; | |||
|
|
|||
| public class ValidationException extends Exception { | |||
| public class ValidationException extends RuntimeException { | |||
There was a problem hiding this comment.
This is required so that the functional command routing doesnt need try/catch -> throw another error
| throw new IllegalStateException(e); | ||
| } | ||
| }; | ||
| } |
There was a problem hiding this comment.
Nice,
So in later PRs, wall those statement methods can be moved to their own services so that the API will only be about declarations and initial parameter processing/validation.
| private AbstractResponse process() { | ||
| return AbstractResponse.createEmptyResponse(); | ||
| } | ||
| } |
There was a problem hiding this comment.
If you couldn't get JAX-RS to work you shouldn't have added your experiments to the PR
There was a problem hiding this comment.
I could make it work, but it would change all API paths and calling method. So i left it at this for now.
I left it for us to decide what to do with them. Ill stash them in a local branch
| * | ||
| */ | ||
| @ApplicationPath("") | ||
| public class RestEasy extends Application implements RestConnector { |
There was a problem hiding this comment.
You made your own resteasy implementation?
Does it have anything to do with this
https://github.com/resteasy/Resteasy/ ?
Because the name is confusing
There was a problem hiding this comment.
Yes it uses the RestEasy implementation provided through UndertowJaxrsServer, what name would you give it? UndertowJaxrsRestEasy? :)
| @@ -125,6 +125,19 @@ | |||
| <artifactId>undertow-websockets-jsr</artifactId> | |||
| <version>${undertow.version}</version> | |||
| </dependency> | |||
|
|
|||
| <!-- RESTEasy Undertow Integration --> | |||
There was a problem hiding this comment.
add digest rules to the enforcer:
Lines 369 to 383 in 9821a60
There was a problem hiding this comment.
2 little changes and that is all :-)
API still has some reworking to do but we shall wait for #874
| try { | ||
| return getTransactionsToApproveStatement(depth, reference); | ||
| } catch (Exception e) { | ||
| throw new IllegalStateException(e); |
There was a problem hiding this comment.
If you drill down to getTransactionsToApproveStatement you will see that it doesn't really throw any exception. So you can remove this wrapping.
| log.error("API Validation failed: " + e.getLocalizedMessage()); | ||
| return ExceptionResponse.create(e.getLocalizedMessage()); | ||
| } catch (final IllegalStateException e) { | ||
| log.error("API Exception: " + e.getLocalizedMessage()); | ||
| return ExceptionResponse.create(e.getLocalizedMessage()); | ||
| } |
There was a problem hiding this comment.
Perhaps add a clause for unexpected problems we don't foresee
catch (RuntimeException e) {
log.error("Unexpected API Exception: " + e.getLocalizedMessage());
return ExceptionResponse.create(e.getLocalizedMessage());
}
While you are at it, please remove those annoying final from the other catch clauses.
Description
The API.java class is currently very unmaintainable.
This PR will externalize the REST client used, and switch from pure undertow to resteasy with undertow impl for easy switching later on.
API commands are no longer run from inside a switch, but according to the method proposed in #392
Backwards compatible as no changes are made to the request/result requirements.
Fixes #920
The following files are not yet used, but will be needed for #874
Not sure what to do with them
Type of change
How Has This Been Tested?
Added tests for new classes, node ran and API called.
Checklist: