This repository has been archived by the owner on Aug 23, 2020. It is now read-only.
Threading issues in PearlDiver.java #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Indentation with spaces instead of tabs
|
@alfredch nice work |
davassi
added a commit
that referenced
this pull request
Jan 17, 2017
* Enabling (--remote) access. * Updating PearlDiver * UTF8 logo. Support for Repeater. * Fixed regression on attachToTangle * API statement log counter * fixed debug parameter bill * Version 1.1.2.3 * Threading issues in PearlDiver.java (#35) * Thread safety and thread coordination * Update PearlDiver.java Indentation with spaces instead of tabs * Obviated the bitIndex loop * Updated milestone counter and snapshot (#45) * added a new flag (--remote-limit-api) to restrict remote api access * fixed responsechannel handling * added pd unit test to dev * Update pom.xml 1.1.2.3 -> 1.1.2.4 * Update README.md * Update IRI.java
GalRogozinski
pushed a commit
to GalRogozinski/iri
that referenced
this pull request
Mar 26, 2019
Add bazel buildfiles
stplaydog
referenced
this pull request
in StreamUnion/StreamNet
Jun 23, 2019
…ceivedData' with 'pr… (#35) * split process of Transaction out of 'preProcessReceivedData' with 'printStatistics' * add judgement. * throw the exception
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests with attachToTangle for a bundle with 4 txs showed the following situation:
In 7 of 21 cases, one of the 4 nonces was returned as 999999999...
PearlDiver.search() has an IN-OUT-argument. Tracing proved that the the transactionTrits are calculated correctly - for the fault nonces as well - but after return from search(), when using the trits for building the transaction object, the nonce is 999999999... This happens most frequently when the spam loop is active and then a concurrent call to attachToTangle is made.
A further problem is created by the missing join() within the PearDiver thread structure. The worker threads have a chance to continue running when they should terminate because the creator does not care to wait for their termination.