fix: inconsistent error message. (#251)

* fix: inconsistent error message. * feat: add changes document
iotaledger · Aug 26, 2021 · ad57181 · ad57181
1 parent badc31b
commit ad57181
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/.changes/error-types-client.md b/.changes/error-types-client.md
@@ -0,0 +1,5 @@
+---
+"iota-stronghold": patch
+---
+
+- Add `actors::secure::StoreError::NotExisting` as proper error type for correct error handling in client.
diff --git a/client/src/actors/secure.rs b/client/src/actors/secure.rs
@@ -65,6 +65,12 @@ pub enum VaultError {
     AccessError,
 }
 
+#[derive(DeriveError, Debug)]
+pub enum StoreError {
+    #[error("Unable to read from store")]
+    NotExisting,
+}
+
 #[derive(DeriveError, Debug)]
 pub enum SnapshotError {
     #[error("No snapshot present for client id ({0})")]
@@ -654,7 +660,7 @@ impl_handler!(
 
         match self.read_from_store(vault_id.into()) {
             Some(data) => Ok(data),
-            None => Err(anyhow::anyhow!(VaultError::NotExisting)), // semantically wrong, use store error
+            None => Err(anyhow::anyhow!(StoreError::NotExisting)),
         }
     }
 );