Feat p2p #47
Merged
Feat p2p #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothingismagick
suggested changes
Oct 19, 2020
elenaf9
force-pushed
the
feat-p2p
branch
2 times, most recently
from
1f77dec
to
8811ac8
Compare
tensor-programming
suggested changes
Oct 22, 2020
nothingismagick
approved these changes
Nov 27, 2020
engine/communication/Cargo.toml
Outdated
| thiserror = "1.0.21" | ||
| serde = { version = "1.0.117", default-features = false, features = ["alloc", "derive"] } | ||
| serde_json = { version = "1.0.59", default-features = false, features = ["alloc"] } | ||
| riker = "0.4.1" |
There was a problem hiding this comment.
Riker 0.4.2 was just published, so this is now out of date. In order to stay 'synced' with the client deps, please drop the patch versions for now. At some point we may return to this, but I am concerned that things stop working in concert if we don't have parity.
engine/communication/Cargo.toml
Outdated
| @@ -0,0 +1,29 @@ | |||
| [package] | |||
| name = "communication" | |||
There was a problem hiding this comment.
Suggested change
| name = "communication" | |
| name = "stronghold-communication" |
engine/communication/Cargo.toml
Outdated
| version = "0.1.0" | ||
| authors = ["Elena Frank <elena.frank@iota.org>"] | ||
| edition = "2018" | ||
| license = "Apache-2.0 OR MIT" |
There was a problem hiding this comment.
Suggested change
| license = "Apache-2.0 OR MIT" | |
| license = "Apache-2.0" |
elenaf9
force-pushed
the
feat-p2p
branch
2 times, most recently
from
e11d42d
to
0823734
Compare
tensor-programming
suggested changes
Dec 4, 2020
communication/examples/local-echo.rs
Outdated
| } | ||
|
|
||
| fn handle_input_line(swarm: &mut Swarm<P2PNetworkBehaviour<Request, Response>>, line: String) { | ||
| if let Some(peer_id) = Regex::new("PING\\s+\"(\\w+)\"") |
There was a problem hiding this comment.
Little verbose on the if branches. Would be better if you put most of the internal logic into the body of the if checks so that it doesn't have to execute it every time.
tensor-programming
approved these changes
Dec 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Enable communication between peers by using rust-libp2p and a mailbox concept for peers that can not communicate directly.
Type of change
Change checklist