Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Link up trit-based checksums #1172

Merged
merged 3 commits into from
Mar 19, 2019
Merged

Link up trit-based checksums #1172

merged 3 commits into from
Mar 19, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Mar 7, 2019 •
edited
Loading

Description

Link up trit based (seed) checksums

Type of change

  • Enhancements

How Has This Been Tested?

  • Unit test coverage
  • Manually tested iOS debug

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@laumair laumair added the L - WIP Lifecycle - Work in Progress label Mar 7, 2019
@laumair laumair added T - Enhancement New feature or request C - Mobile C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this E - Functional Epic - Relating to how a feature works and removed L - WIP Lifecycle - Work in Progress labels Mar 7, 2019
@rajivshah3 rajivshah3 merged commit 685d54f into iotaledger:develop Mar 19, 2019
@rajivshah3 rajivshah3 mentioned this pull request Mar 21, 2019
Merged
@laumair laumair deleted the feat/trit-checksums branch March 21, 2019 23:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rajivshah3 rajivshah3 rajivshah3 approved these changes

Assignees
No one assigned
Labels
C - Mobile C - Shared E - Functional Epic - Relating to how a feature works L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this T - Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laumair @rajivshah3