Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Refactor keychain wrapper object (Remove unnecessary promises) #1196

Merged
merged 1 commit into from
Mar 21, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Mar 21, 2019

Description

Since keychain methods already return promises, there was no need for them to be wrapped in Promise constructors.

Type of change

  • Refactor

How Has This Been Tested?

N/A

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@laumair laumair added C - Mobile L - Need reviews Lifecycle - Each PR must have at least two reviewers E - Refactor Epic - Improving code readability and maintainability labels Mar 21, 2019
Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Mobile E - Refactor Epic - Improving code readability and maintainability L - Need reviews Lifecycle - Each PR must have at least two reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants