This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Mobile/iOS: Fix NSLocationAlwaysUsageDescription purpose string #1224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
added
T - Bug
rajivshah3
force-pushed
the
fix/ios-info-plist
branch
from
18ffab3
to
bb803d4
Compare
rajivshah3
added
P1 - Critical
|
Marking as critical because iOS builds will be rejected without this fix |
cvarley100
approved these changes
Apr 4, 2019
rajivshah3
added a commit
that referenced
this pull request
Apr 23, 2019
rajivshah3
added a commit
that referenced
this pull request
Apr 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes
NSLocationAlwaysUsageDescriptionpurpose string to satisfy App Store requirements. Build 50 was rejected because this was not specified in the Info.plist.Note: This string should not appear during normal app use because Trinity never needs access to your location. This is simply to satisfy App Store requirements.
Type of change
How Has This Been Tested?
N/A
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes