This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Mobile: Ensure seed reentry input only accepts A-Z9 #1239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
reviewed
Apr 2, 2019
| @@ -87,7 +87,7 @@ class SeedReentry extends Component { | |||
| constructor() { | |||
| super(); | |||
| this.state = { | |||
| reenteredSeed: null, | |||
| reenteredSeed: '', | |||
There was a problem hiding this comment.
I think this change might break QR code scanning. On line 158 we set reenteredSeed to a trit value:
this.setState({ reenteredSeed: trytesToTrits(data) });Since trytesToTrits returns an Int8Array I don't think we can initialize it to an empty string
There was a problem hiding this comment.
It doesn't break it
rajivshah3
approved these changes
Apr 4, 2019
This was referenced Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
Tested on iOS Simulator
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes