This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Wait for SeedStore constructor promise to resolve before making a retry attempt #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laumair
added
C - Mobile
L - Need reviews
rajivshah3
approved these changes
Apr 9, 2019
rihardsgravis
pushed a commit
that referenced
this pull request
Apr 12, 2019
* develop: (155 commits) Bump electron from 3.1.6 to 3.1.8 in /src/desktop (#1294) Bump react-transition-group from 2.7.1 to 2.9.0 in /src/desktop (#1273) Bump css-loader from 2.1.0 to 2.1.1 in /src/desktop (#1262) Bump electron-builder from 20.38.5 to 20.39.0 in /src/desktop (#1261) Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1290) Bump snyk from 1.149.0 to 1.150.0 (#1289) Bump fastlane from 2.119.0 to 2.120.0 in /src/mobile/ios (#1288) Bump fastlane from 2.119.0 to 2.120.0 in /src/mobile/android (#1287) Bump snyk from 1.148.0 to 1.149.0 (#1286) Shared: Add node request timeouts for getTransactionsToApprove endpoint (#1284) Mobile: Wait for SeedStore constructor promise to resolve before making a retry attempt (#1283) Bump snyk from 1.147.4 to 1.148.0 (#1279) Mobile: Minor changes to seed text input (#1244) New Crowdin translations (#1252) Mobile: Reenable and refactor deep linking (#1143) Only convert transactions to normalised transactions if notification function is defined (#1276) feat: add realm migration from v1 to v2 (#1274) Mobile: Fix AsyncStorage migration (#1272) Bump webpack-dev-middleware from 3.6.0 to 3.6.2 in /src/desktop (#1264) Bump snyk from 1.147.3 to 1.147.4 (#1270) ... # Conflicts: # package.json # src/desktop/native/Entangled.js # src/desktop/package.json # src/desktop/src/index.js # src/desktop/src/libs/crypto.js # src/desktop/src/ui/components/Balance.js # src/desktop/src/ui/components/List.js # src/desktop/src/ui/global/Theme.js # src/desktop/src/ui/views/settings/account/Addresses.js # src/desktop/src/ui/views/wallet/Sidebar.js # src/shared/libs/currency.js
This was referenced Apr 16, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We didn't wait for for seedStore instantiation promise to resolve before passing it to prop method
retryFailedTransactioninPollcomponent (mobile) leading to unhandled exceptions. This PR fixes the issue.Type of change
How Has This Been Tested?
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodesshared: If applicable, I have verified that my changes are implemented correctly indesktopandmobile