Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Mobile: Fix fingerprint widget bugs on login #1357

Merged
merged 2 commits into from
Apr 20, 2019
Merged

Conversation

rajivshah3
Copy link
Member

Description

Only show fingerprintDisabled and fingerprint widgets if isFingerprintEnabled is true (Biometric authentication is enabled)

Fixes #1342

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

  • Tested manually on iOS
  • Added unit tests for EnterPasswordOnLogin component

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working C - Mobile L - Need reviews Lifecycle - Each PR must have at least two reviewers E - UI/UX Epic - Improving user interface/user experience labels Apr 19, 2019
@rajivshah3 rajivshah3 added the P3 - Medium Priority - Normal priority label Apr 19, 2019
@rajivshah3 rajivshah3 changed the title Mobile: Fix fingerprint bugs on login Mobile: Fix fingerprint widget bugs on login Apr 19, 2019
@rajivshah3 rajivshah3 merged commit 537e1b3 into develop Apr 20, 2019
@rajivshah3 rajivshah3 deleted the fix/fingerprint-login branch April 20, 2019 18:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Mobile E - UI/UX Epic - Improving user interface/user experience L - Need reviews Lifecycle - Each PR must have at least two reviewers P3 - Medium Priority - Normal priority T - Bug Type - Bug: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unlocking with fingerprint is possible although it is disabled in settings
2 participants