Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Make sure we remove unnecessary realm storage files on deprecated storage path #1358

Merged
merged 1 commit into from
Apr 20, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Apr 19, 2019

Description

Realm.schemaVersion(path) generates realm files at provided path. These files are unnecessary and should be removed. This PR fixes this issue by manually removing generated realm files at deprecated path.

Type of change

  • Bug fix

How Has This Been Tested?

  • Manually tested iOS (debug)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@laumair laumair added T - Bug Type - Bug: Something isn't working C - Shared P2 - High Priority - Prefer to fix or merge this labels Apr 19, 2019
Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS ✅

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Shared P2 - High Priority - Prefer to fix or merge this T - Bug Type - Bug: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants