Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Update max milestone threshold value #1392

Merged
merged 2 commits into from
Apr 25, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Apr 25, 2019

Description

  • Update wallet's default node to https://nodes.iota.org
  • Update max milestone threshold value. Max milestone threshold is the value used for node sync checks. This value determines how far behind in milestones a node can be. Previously, it was set to 1 which is quite restrictive and often leads to "out of sync" errors.

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Updated unit tests

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

Max milestone threshold is the value used for node sync checks. This value determines how far behind in milestones a node can be. Previously, it was set to 1 which is quite restrictive and often leads to "out of sync" errors.

This commit increases the threshold from 1 -> 2.
@laumair laumair changed the title Feat/max milestone fallbehind Update max milestone threshold value Apr 25, 2019
@laumair laumair added C - Shared P2 - High Priority - Prefer to fix or merge this T - Enhancement New feature or request labels Apr 25, 2019
@laumair laumair marked this pull request as ready for review April 25, 2019 17:07
@rajivshah3 rajivshah3 merged commit fd501ce into iotaledger:develop Apr 25, 2019
@cvarley100 cvarley100 mentioned this pull request May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Shared P2 - High Priority - Prefer to fix or merge this T - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants