This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Shared: Fix extra parameter in fn call when reattaching and promoting #1503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
added
T - Bug
rihardsgravis
pushed a commit
that referenced
this pull request
May 13, 2019
* develop: Shared: Fix extra parameter in fn call when reattaching and promoting (#1503) Mobile: Bump handlebars to 4.1.2 (#1454) Mobile/iOS: Patch react-native run-ios (#1505) Bump url-parse from 1.4.3 to 1.4.7 in /src/shared (#1453) Bump proxy-polyfill from 9c009d7 to 0.3.0 in /src/shared (#1449) Bump snyk from 1.163.1 to 1.163.3 (#1499) Bump react-transition-group from 4.0.0 to 4.0.1 in /src/desktop (#1497) - Update Bugsnag dependency usage (#1493) Bump snyk from 1.163.0 to 1.163.1 (#1495) # Conflicts: # src/desktop/src/index.js # src/shared/store.js
rihardsgravis
pushed a commit
that referenced
this pull request
May 13, 2019
* develop: Bump react-dev-utils from 9.0.0 to 9.0.1 in /src/desktop (#1490) Bump electron-builder from 20.39.0 to 20.40.2 in /src/desktop (#1496) Bump webpack from 4.30.0 to 4.31.0 in /src/desktop (#1500) Shared: Fix extra parameter in fn call when reattaching and promoting (#1503) Mobile: Bump handlebars to 4.1.2 (#1454) Mobile/iOS: Patch react-native run-ios (#1505) Bump url-parse from 1.4.3 to 1.4.7 in /src/shared (#1453) Bump proxy-polyfill from 9c009d7 to 0.3.0 in /src/shared (#1449) Bump snyk from 1.163.1 to 1.163.3 (#1499) Bump react-transition-group from 4.0.0 to 4.0.1 in /src/desktop (#1497) - Update Bugsnag dependency usage (#1493) Bump snyk from 1.163.0 to 1.163.1 (#1495) # Conflicts: # src/desktop/bugsnag.js # src/desktop/npm-shrinkwrap.json # src/desktop/package.json # src/shared/store.js
This was referenced May 23, 2019
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
syncAccountAfterReattachmentwas called with an extra parameter when reattaching and promoting a transaction. This resulted in an error that saidaccountState.transactions is not iterableorCannot read property 'Symbol(Symbol.iterator)' of undefined.Type of change
How Has This Been Tested?
Checklist:
shared: If applicable, I have verified that my changes are implemented correctly indesktopandmobile