Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Desktop: Catch and display preload and initialisation errors #1549

Merged
merged 6 commits into from
May 20, 2019

Conversation

rihardsgravis
Copy link
Contributor

@rihardsgravis rihardsgravis commented May 17, 2019

Description

Show to the user:

  • Error output if the wallet could not be initialised correctly
  • Errors on the Electron preload script

Previously the wallet did not display the main window, but the process was running in the background.

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Tested on macOS

Checklist:

Please delete items that are not relevant.

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@rihardsgravis rihardsgravis added C - Desktop L - Need reviews Lifecycle - Each PR must have at least two reviewers E - Functional Epic - Relating to how a feature works labels May 17, 2019
@rihardsgravis rihardsgravis self-assigned this May 17, 2019
Copy link
Member

@rajivshah3 rajivshah3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@rajivshah3 rajivshah3 merged commit 6f89525 into develop May 20, 2019
@rajivshah3 rajivshah3 deleted the feat/desktop-binary-error-fix branch May 20, 2019 13:25
rihardsgravis pushed a commit that referenced this pull request May 20, 2019
* develop:
  Bump timekeeper from 2.0.0 to 2.2.0 in /src/shared (#1507)
  Bump bignumber.js from 8.0.1 to 8.1.1 in /src/shared (#1545)
  New Crowdin translations (#1516)
  Desktop: Catch and display preload and initialisation errors (#1549)
  Remove auditjs (#1553)
  Revert and lock to `usb` `1.5.0` (#1558)
  Desktop: Update ledger warning string (#1557)
  Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1555)
  Bump appcompat-v7 from 27.1.0 to 28.0.0 in /src/mobile/android (#961)
  Bump snyk from 1.165.0 to 1.165.1 (#1552)
  Desktop: Improve UX during Ledger setup (#1550)
  Shared: Improvements to alerts (#1488)
  Shared: Add device time suggestion to out of sync errors (#1485)
  Bump eslint-config-prettier from 4.2.0 to 4.3.0 (#1546)
  Bump express from 4.16.4 to 4.17.0 in /src/desktop (#1547)
  Bump keytar from 4.6.0 to 4.7.0 in /src/desktop (#1548)
  fix: ignore transition addresses if a user swaps account (#1528)
  Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1504)

# Conflicts:
#	src/mobile/src/ui/views/wallet/ChangePassword.js
#	src/shared/actions/wallet.js
rihardsgravis pushed a commit that referenced this pull request May 20, 2019
* develop:
  Bump timekeeper from 2.0.0 to 2.2.0 in /src/shared (#1507)
  Bump bignumber.js from 8.0.1 to 8.1.1 in /src/shared (#1545)
  New Crowdin translations (#1516)
  Desktop: Catch and display preload and initialisation errors (#1549)
  Remove auditjs (#1553)
  Revert and lock to `usb` `1.5.0` (#1558)
  Desktop: Update ledger warning string (#1557)

# Conflicts:
#	src/desktop/package.json
#	src/desktop/src/index.js
rihardsgravis pushed a commit that referenced this pull request May 21, 2019
* feat/nodes-granularity: (48 commits)
  fix: update/fix failing tests
  Bump timekeeper from 2.0.0 to 2.2.0 in /src/shared (#1507)
  Bump bignumber.js from 8.0.1 to 8.1.1 in /src/shared (#1545)
  New Crowdin translations (#1516)
  Desktop: Catch and display preload and initialisation errors (#1549)
  Remove auditjs (#1553)
  feat: make sure prepareTransfer method of SeedStore class accept node settings parameter
  Revert and lock to `usb` `1.5.0` (#1558)
  feat: make sure promotion & reattachment actions are wrapped inside NodeManager.withRetries method
  feat: make sure @iota/core methods are passed with username & password
  Desktop: Update ledger warning string (#1557)
  Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1555)
  Bump appcompat-v7 from 27.1.0 to 28.0.0 in /src/mobile/android (#961)
  Bump snyk from 1.165.0 to 1.165.1 (#1552)
  Desktop: Improve UX during Ledger setup (#1550)
  Shared: Improvements to alerts (#1488)
  feat: add password property in nodes data
  Shared: Add device time suggestion to out of sync errors (#1485)
  Bump eslint-config-prettier from 4.2.0 to 4.3.0 (#1546)
  Bump express from 4.16.4 to 4.17.0 in /src/desktop (#1547)
  ...

# Conflicts:
#	src/mobile/src/ui/views/wallet/ChangePassword.js
rihardsgravis pushed a commit that referenced this pull request May 22, 2019
* develop: (49 commits)
  Desktop: Use executable icon for application window
  Desktop: Lock node-usb to 1.5.0 (#1580)
  Bump snyk from 1.165.1 to 1.166.0 (#1570)
  Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1562)
  Bump i18next from 15.1.1 to 15.1.2 in /src/desktop (#1561)
  Bump webpack from 4.31.0 to 4.32.0 in /src/desktop (#1564)
  Bump recharts from 1.6.0 to 1.6.1 in /src/desktop (#1567)
  Bump timekeeper from 2.0.0 to 2.2.0 in /src/shared (#1507)
  Bump bignumber.js from 8.0.1 to 8.1.1 in /src/shared (#1545)
  New Crowdin translations (#1516)
  Desktop: Catch and display preload and initialisation errors (#1549)
  Remove auditjs (#1553)
  Revert and lock to `usb` `1.5.0` (#1558)
  Desktop: Update ledger warning string (#1557)
  Bump @ledgerhq/hw-transport-node-hid in /src/desktop (#1555)
  Bump appcompat-v7 from 27.1.0 to 28.0.0 in /src/mobile/android (#961)
  Bump snyk from 1.165.0 to 1.165.1 (#1552)
  Desktop: Improve UX during Ledger setup (#1550)
  Shared: Improvements to alerts (#1488)
  Shared: Add device time suggestion to out of sync errors (#1485)
  ...

# Conflicts:
#	src/desktop/src/index.js
#	src/desktop/src/ui/global/FatalError.js
#	src/shared/store.js
This was referenced May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Desktop E - Functional Epic - Relating to how a feature works L - Need reviews Lifecycle - Each PR must have at least two reviewers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants