Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Add seed validation #1674

Merged
merged 3 commits into from
May 31, 2019
Merged

Add seed validation #1674

merged 3 commits into from
May 31, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented May 31, 2019

Description

  • Validate seed before address generation in SeedStore (mobile)
  • Validate seed length before address generation in (iOS & android) Native Modules methods

Type of change

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Manually tested iOS simulator iPhone 7 Plus

Note: Not tested on android.

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@laumair laumair added C - Mobile C - Shared E - Security Epic - Security related L - Need reviews Lifecycle - Each PR must have at least two reviewers labels May 31, 2019
@laumair laumair self-assigned this May 31, 2019
@cvarley100 cvarley100 merged commit 5af63b2 into iotaledger:develop May 31, 2019
rihardsgravis pushed a commit that referenced this pull request Jun 4, 2019
Merge branch 'develop' into desktop-0.6.0
24cb59f 
* develop:
  Bump i18next from 15.1.3 to 16.0.0 in /src/desktop (#1696)
  Bump @ledgerhq/hw-transport-node-hid from 4.60.3 to 4.61.1 in /src/desktop (#1702)
  Bump enzyme from 3.9.0 to 3.10.0 in /src/desktop (#1697)
  Bump enzyme-adapter-react-16 from 1.13.2 to 1.14.0 in /src/desktop (#1703)
  Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/ios (#1700)
  Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/android (#1699)
  Bump snyk from 1.170.0 to 1.171.1 (#1701)
  Bump electron from 3.1.9 to 3.1.10 in /src/desktop (#1662)
  Bump mini-css-extract-plugin from 0.6.0 to 0.7.0 in /src/desktop (#1661)
  Bump dart-sass from 1.20.1 to 1.20.3 in /src/desktop (#1676)
  [Security] Bump axios from 0.18.0 to 0.18.1 in /src/mobile (#1686)
  [Security] Bump axios from 0.18.0 to 0.18.1 in /src/shared (#1675)
  Bump @jest-runner/electron from 1.1.1 to 2.0.0 in /src/desktop (#1664)
  New Crowdin translations (#1657)
  Add seed validation (#1674)
  Bump fastlane from 2.123.0 to 2.124.0 in /src/mobile/android (#1669)
  Bump fastlane from 2.123.0 to 2.124.0 in /src/mobile/ios (#1670)
rihardsgravis pushed a commit that referenced this pull request Jun 4, 2019
Merge branch 'develop' into dependabot/npm_and_yarn/eslint-config-air…
0472231 
…bnb-17.1.0

* develop: (83 commits)
  Bump i18next from 15.1.3 to 16.0.0 in /src/desktop (#1696)
  Bump @ledgerhq/hw-transport-node-hid from 4.60.3 to 4.61.1 in /src/desktop (#1702)
  Bump enzyme from 3.9.0 to 3.10.0 in /src/desktop (#1697)
  Bump enzyme-adapter-react-16 from 1.13.2 to 1.14.0 in /src/desktop (#1703)
  Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/ios (#1700)
  Bump fastlane from 2.124.0 to 2.125.2 in /src/mobile/android (#1699)
  Bump snyk from 1.170.0 to 1.171.1 (#1701)
  Bump electron from 3.1.9 to 3.1.10 in /src/desktop (#1662)
  Bump mini-css-extract-plugin from 0.6.0 to 0.7.0 in /src/desktop (#1661)
  Bump dart-sass from 1.20.1 to 1.20.3 in /src/desktop (#1676)
  [Security] Bump axios from 0.18.0 to 0.18.1 in /src/mobile (#1686)
  [Security] Bump axios from 0.18.0 to 0.18.1 in /src/shared (#1675)
  Bump @jest-runner/electron from 1.1.1 to 2.0.0 in /src/desktop (#1664)
  New Crowdin translations (#1657)
  Add seed validation (#1674)
  Bump fastlane from 2.123.0 to 2.124.0 in /src/mobile/android (#1669)
  Bump fastlane from 2.123.0 to 2.124.0 in /src/mobile/ios (#1670)
  Deskop 0.5.2 release (#1656)
  Bump react-transition-group from 4.0.1 to 4.1.0 in /src/desktop (#1663)
  Desktop `0.5.2` version bump (#1668)
  ...

# Conflicts:
#	src/desktop/src/ui/views/wallet/Send.js
@rajivshah3 rajivshah3 mentioned this pull request Jun 13, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cvarley100 cvarley100 cvarley100 approved these changes

Assignees

@laumair laumair

Labels
C - Mobile C - Shared E - Security Epic - Security related L - Need reviews Lifecycle - Each PR must have at least two reviewers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@laumair @cvarley100