This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Shared: Prevent Cannot read property message of undefined in error catches
#1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarley100
approved these changes
Jun 20, 2019
rihardsgravis
pushed a commit
that referenced
this pull request
Jun 21, 2019
* develop: (24 commits) Desktop: Prepare 0.6.2 release (#1837) New Crowdin translations (#1826) Shared: Add more verbose error log messages (#1834) Shared: Fix bugs associated with quorum (#1835) Shared: Add fallback node list api endpoints (#1811) fix: 0.4.x -> latest database migration (#1832) Try not to error in error catches (#1833) fix: handle exception if salt is missing from keychain (#1772) Bump babel-eslint from 10.0.1 to 10.0.2 (#1804) Bump svg2ttf from 4.1.0 to 4.3.0 in /src/shared (#1764) New Crowdin translations (#1825) Mobile: Bump build no to 72 (#1824) New Crowdin translations (#1823) New Crowdin translations (#1813) fix: wrap all used methods in #makeTransaction in NodesManager.retry (#1812) feat: update redux schema before migration (#1818) feat: remove locally stored unhealthy nodes (#1810) Revert "Bump appcompat-v7 from 27.1.0 to 28.0.0 in /src/mobile/android (#961)" (#1822) Mobile/Android: Patch react-native-device-info (#1821) Mobile: Update yarn.lock (#1819) ... # Conflicts: # src/desktop/src/index.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Errors in error catches should be checked to be instance of
Erroror if it actually has amessagekey, otherwise the catch can fail with an error itself.Type of change
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodesshared: If applicable, I have verified that my changes are implemented correctly indesktopandmobile