Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

fix: MoonPay enhancements/fixes #2451

Merged
merged 20 commits into from
Jan 20, 2020
Merged

fix: MoonPay enhancements/fixes #2451

merged 20 commits into from
Jan 20, 2020

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Jan 6, 2020 •
edited
Loading

Description

Fixes and enhancements to MoonPay registration and purchase process:

  • Use placeholder for DOB field
  • Validate DOBs
  • Convert commas to periods when used as decimal separators
  • Hide US from country list until US support is added
  • Fix crash on country dropdown list
  • Minor fixes to translation strings

Fixes #2400
Fixes #2480
Fixes #2477
Fixes #2478
Fixes #2481

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

  • Tested on iOS simulator

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working T - Enhancement New feature or request L - WIP Lifecycle - Work in Progress E - UI/UX Epic - Improving user interface/user experience E - Functional Epic - Relating to how a feature works labels Jan 6, 2020
@cvarley100
Copy link
Contributor

Is there a reason this is mobile only?

@rajivshah3
Copy link
Member Author

I happened to start on mobile and was planning to do desktop afterwards

@cvarley100 cvarley100 changed the title WIP: fix: MoonPay enhancements/fixes fix: MoonPay enhancements/fixes Jan 16, 2020
@cvarley100 cvarley100 marked this pull request as ready for review January 16, 2020 17:29
@rajivshah3 rajivshah3 removed the L - WIP Lifecycle - Work in Progress label Jan 16, 2020
laumair
laumair approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@laumair laumair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work.

@cvarley100 cvarley100 merged commit 8d6c1dc into develop Jan 20, 2020
@cvarley100 cvarley100 mentioned this pull request Jan 20, 2020
Merged
@rajivshah3 rajivshah3 deleted the fix/moonpay-usability branch January 20, 2020 17:40
@cvarley100 cvarley100 mentioned this pull request Feb 10, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@laumair laumair laumair approved these changes

@rihardsgravis rihardsgravis Awaiting requested review from rihardsgravis

Assignees
No one assigned
Labels
C - Desktop C - Mobile E - Functional Epic - Relating to how a feature works E - UI/UX Epic - Improving user interface/user experience T - Bug Type - Bug: Something isn't working T - Enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@rajivshah3 @cvarley100 @laumair