This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
fix/mobile: autocapitalise seed entry #2502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
holiman
reviewed
Feb 14, 2020
| @@ -226,10 +226,11 @@ class CustomTextInput extends Component { | |||
| onChangeText(value) { | |||
| const { isPasswordInput, isSeedInput, onValidTextChange } = this.props; | |||
| if (isSeedInput) { | |||
| if (value && !value.match(VALID_SEED_REGEX)) { | |||
| const valueCapitalized = value.toUpperCase() | |||
| if (valueCapitalized && !valueCapitalized.match(VALID_SEED_REGEX)) { | |||
There was a problem hiding this comment.
Both before this change and after -- so if valueCapitalized is "", the regex-check won't trigger, and the empty seed will go to onValidTextChange -- ?
There was a problem hiding this comment.
Should probably be
if (!valueCapitalized || !valueCapitalized.match(VALID_SEED_REGEX)) {
return;
}
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Autocapitalises seed on entry.
Fixes #2501
Type of change
How Has This Been Tested?
Tested on Android and iOS
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes