Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Fix(shared): Fix issues with currency and timeframe settings #2771

Merged
merged 3 commits into from
May 8, 2020
Merged

Fix(shared): Fix issues with currency and timeframe settings #2771

merged 3 commits into from
May 8, 2020

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented May 5, 2020 •
edited
Loading

Description of change

  • Fixes an bug where setting the chart currency caused the currency in Realm to be set to the same value. This led to an inconsistency between Realm and Redux when the app is relaunched.

  • Fixes chart currency and timeframe not persisting across relaunches

Fixes #2529

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)

How the change has been tested

  • Tested on macOS (dev)

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

@rajivshah3 rajivshah3 added T - Bug Type - Bug: Something isn't working C - Shared L - WIP Lifecycle - Work in Progress labels May 5, 2020
@rajivshah3 rajivshah3 self-assigned this May 5, 2020
@rajivshah3
Copy link
Member Author

To reproduce the issue:

  1. Go into settings and change currency to CAD
  2. Reload app — after logging in, balance is shown in USD
  3. Change chart currency to EUR
  4. Reload app — after logging in, balance is shown in EUR but the chart has reset to USD

@cvarley100 cvarley100 changed the title WIP: fix(shared): Fix issues with currency and timeframe settings Fix(shared): Fix issues with currency and timeframe settings May 8, 2020
@cvarley100
Copy link
Contributor

Have fixed persistence

@rajivshah3 rajivshah3 marked this pull request as ready for review May 8, 2020 15:04
@rajivshah3 rajivshah3 added L - Need reviews Lifecycle - Each PR must have at least two reviewers and removed L - WIP Lifecycle - Work in Progress labels May 8, 2020
@rajivshah3 rajivshah3 added this to In progress in Trinity via automation May 8, 2020
@rajivshah3 rajivshah3 moved this from In progress to Review needed in Trinity May 8, 2020
Trinity automation moved this from Review needed to Reviewer approved May 8, 2020
@cvarley100 cvarley100 merged commit 8685638 into develop May 8, 2020
Trinity automation moved this from Reviewer approved to Done May 8, 2020
@rajivshah3 rajivshah3 deleted the fix/chart-currency-timeframe branch May 8, 2020 15:07
This was referenced May 8, 2020
Merged
Merged
@rajivshah3 rajivshah3 mentioned this pull request May 18, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cvarley100 cvarley100 cvarley100 approved these changes

@laumair laumair Awaiting requested review from laumair

Assignees

@rajivshah3 rajivshah3

Labels
C - Shared L - Need reviews Lifecycle - Each PR must have at least two reviewers T - Bug Type - Bug: Something isn't working
Projects
Trinity
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Currency/timeframe reset after app restart
2 participants
@rajivshah3 @cvarley100