Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

fix(desktop): Bump electron to 9.4.4 #3177

Merged
merged 12 commits into from Mar 20, 2021
Merged

fix(desktop): Bump electron to 9.4.4 #3177

merged 12 commits into from Mar 20, 2021

Conversation

rajivshah3
Copy link
Member

@rajivshah3 rajivshah3 commented Dec 21, 2020 •
edited

Description of change

Bumps electron to 9.4.1

Type of change

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)

How the change has been tested

  • Tested on macOS
  • Tested on Windows
  • Tested on Ubuntu

Change checklist

  • My code follows the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing unit tests pass locally with my changes

@rajivshah3 rajivshah3 added C - Desktop E - Security Epic - Security related L - WIP Lifecycle - Work in Progress labels Dec 21, 2020
@rajivshah3 rajivshah3 added this to In progress in Trinity via automation Dec 21, 2020
@rajivshah3 rajivshah3 mentioned this pull request Dec 21, 2020
Closed
@rajivshah3 rajivshah3 mentioned this pull request Jan 15, 2021
Closed
@rajivshah3 rajivshah3 changed the title fix(desktop): Bump electron to 9.4.0 fix(desktop): Bump electron to 9.4.1 Jan 15, 2021
@rajivshah3 rajivshah3 removed the L - WIP Lifecycle - Work in Progress label Jan 21, 2021
@rajivshah3 rajivshah3 moved this from In progress to Review needed in Trinity Jan 21, 2021
@rajivshah3 rajivshah3 marked this pull request as ready for review January 21, 2021 22:35
@laumair
Copy link
Contributor

laumair commented Mar 10, 2021

@rajivshah3 This looks good. However, for some reason I think this update might be suppressing an error around Content Security Policy. I faced it when I try to update Electron to 9.4.0. I am not sure why I can't seem to reproduce it on this branch 🤔

This was referenced Mar 15, 2021
Closed
Closed
Closed
@rajivshah3 rajivshah3 changed the title fix(desktop): Bump electron to 9.4.1 fix(desktop): Bump electron to 9.4.4 Mar 15, 2021
@rajivshah3 rajivshah3 mentioned this pull request Mar 15, 2021
Closed
Trinity automation moved this from Review needed to Reviewer approved Mar 20, 2021
@cvarley100 cvarley100 merged commit 99959df into develop Mar 20, 2021
Trinity automation moved this from Reviewer approved to Done Mar 20, 2021
@rajivshah3 rajivshah3 deleted the fix/electron-9 branch March 21, 2021 02:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cvarley100 cvarley100 cvarley100 approved these changes

Assignees
No one assigned
Labels
C - Desktop E - Security Epic - Security related
Projects
Trinity
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rajivshah3 @laumair @cvarley100