Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Desktop: Fix account addition error check #578

Merged
merged 2 commits into from Nov 6, 2018
Merged

Desktop: Fix account addition error check #578

merged 2 commits into from Nov 6, 2018

Conversation

rihardsgravis
Copy link
Contributor

@rihardsgravis rihardsgravis commented Nov 5, 2018 •
edited

Description

  • Mark Onboarding as complete only on successful account addition
  • Fix account addition check
  • Catch Keychain unavailability on Login

Fixes #498

Type of change

  • Bug fix (a non-breaking change which fixes an issue)

How Has This Been Tested?

Tested manually on macOS

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas

@rihardsgravis rihardsgravis added C - Desktop P3 - Medium Priority - Normal priority labels Nov 5, 2018
@rihardsgravis rihardsgravis self-assigned this Nov 5, 2018
@rihardsgravis rihardsgravis changed the title [Desktop] Fix account addition error check Desktop: Fix account addition error check Nov 5, 2018
@rajivshah3 rajivshah3 added the T - Bug Type - Bug: Something isn't working label Nov 6, 2018
@cvarley100 cvarley100 merged commit ba87dd9 into develop Nov 6, 2018
@rihardsgravis rihardsgravis mentioned this pull request Nov 7, 2018
Merged
2 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@cvarley100 cvarley100 cvarley100 approved these changes

@laumair laumair Awaiting requested review from laumair

Assignees

@rihardsgravis rihardsgravis

Labels
C - Desktop P3 - Medium Priority - Normal priority T - Bug Type - Bug: Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unresponsive on Login-Dialog
3 participants
@rihardsgravis @cvarley100 @rajivshah3