Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile: Require manual address generation #608

Merged
merged 5 commits into from Nov 19, 2018

Conversation

Projects
None yet
3 participants
@cvarley100
Copy link
Member

commented Nov 19, 2018

Description

  • Requires manual address generation on mobile

Fixes # (issue)

  • Enhancement (a non-breaking change which adds functionality)

How Has This Been Tested?

Tested across Android and iOS

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
@@ -487,17 +496,19 @@ class Receive extends Component {
]).start(() => this.props.flipReceiveCard());
}

blockActionDuringSync() {}

This comment has been minimized.

Copy link
@laumair

laumair Nov 19, 2018

Member

Is this needed?

@laumair
Copy link
Member

left a comment

LGTM!

@rajivshah3 rajivshah3 merged commit 1e3b2c7 into develop Nov 19, 2018

10 checks passed

buildkite/trinity-desktop-prs Build #1033 passed (5 minutes, 52 seconds)
Details
buildkite/trinity-mobile-prs Build #1060 passed (11 minutes, 18 seconds)
Details
buildkite/trinity-shared-prs Build #62 passed (3 minutes, 16 seconds)
Details
ci/bitrise/384139abc249bd17/pr Passed - trinity-desktop
Details
ci/bitrise/e1c71066b5c75521/pr Passed - trinity-mobile
Details
security/snyk - package.json (IOTA Foundation) No manifest changes detected
security/snyk - src/desktop/package.json (IOTA Foundation) No manifest changes detected
security/snyk - src/mobile/android/app/build.gradle (IOTA Foundation) No manifest changes detected
security/snyk - src/mobile/package.json (IOTA Foundation) No new issues
Details
security/snyk - src/shared/package.json (IOTA Foundation) No manifest changes detected

@rajivshah3 rajivshah3 deleted the hotfix/manual-gen-mobile branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.