This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
[WIP] Mobile visual cleanup #669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cvarley100
force-pushed
the
chore/visual-cleanup
branch
from
4cf756b
to
1e99709
Compare
rajivshah3
added
C - Mobile
E - UI/UX
rajivshah3
reviewed
Dec 8, 2018
| if (isAndroid) { | ||
| this.keyboardWillShowSub = Keyboard.addListener('keyboardDidShow', this.keyboardDidShow); | ||
| this.keyboardWillHideSub = Keyboard.addListener('keyboardDidHide', this.keyboardDidHide); | ||
| } |
There was a problem hiding this comment.
Couldn't we just use if-else here instead of two if statements?
| if (!this.props.isModalActive && newProps.isModalActive) { | ||
| if (this.props.isKeyboardActive && !isAndroid) { | ||
| Keyboard.dismiss(); | ||
| return timer.setTimeout('test', () => this.setState({ isModalActive: true }), 2800); |
There was a problem hiding this comment.
Does this timer need to be cleared on unmount?
cvarley100
changed the base branch from
feat/dashboard-animations
to
feat/animations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How Has This Been Tested?
Checklist:
Please delete items that are not relevant.
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes