Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Add additional spend status check #862

Merged
merged 2 commits into from
Jan 2, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Dec 28, 2018

Description

Add additional spend status check for all inputs and outputs just before broadcast

Type of change

  • Enhancement

How Has This Been Tested?

  • Manually tested iOS (dev)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

- Rename shouldAllowSendingToAddress to isAnyAddressSpent
- Returns Promise<true> if any provided address is spent
@laumair laumair added T - Enhancement New feature or request C - Mobile C - Desktop C - Shared E - Security Epic - Security related L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this E - Functional Epic - Relating to how a feature works labels Dec 28, 2018
@rajivshah3 rajivshah3 merged commit 90e17ed into iotaledger:develop Jan 2, 2019
@laumair laumair deleted the feat/additional-spend-checks branch February 15, 2019 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Desktop C - Mobile C - Shared E - Functional Epic - Relating to how a feature works E - Security Epic - Security related L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this T - Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants