This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Fixed some hardcoded strings #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajivshah3
added
C - Mobile
E - UI/UX
rajivshah3
suggested changes
Dec 28, 2018
There was a problem hiding this comment.
Thanks for the PR @mgeier63 ! One small note: Since this is a React component wrapped with withNamespaces, the t function is already passed as a prop and can simply be called with this.props.t. I've suggested changes accordingly. I apologize for the localization docs not being up to date; I'll make sure to update them in a future PR.
rajivshah3
reviewed
Dec 28, 2018
| @@ -133,7 +138,7 @@ class Disable2FA extends Component { | |||
| animationOutType={['slideOutLeft', 'fadeOut']} | |||
| delay={266} | |||
| > | |||
| <Text style={[styles.generalText, textColor]}>Enter your token to disable 2FA</Text> | |||
| <Text style={[styles.generalText, textColor]}>{t('twoFA:enterCode')}</Text> | |||
Co-Authored-By: mgeier63 <mgeier63@gmail.com>
rajivshah3
approved these changes
Dec 29, 2018
|
Thanks @mgeier63 ! Looks good 👍 |
rajivshah3
pushed a commit
that referenced
this pull request
Dec 31, 2018
* using dynamic i18n texts instead of hardcoded english * Apply suggestions from code review / i18n t passed as a prop Co-Authored-By: mgeier63 <mgeier63@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found and fixed some hardcoded strings
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Ran the app and made sure the correct texts were shown.
Checklist:
Please delete items that are not relevant.
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes