Skip to content
This repository has been archived by the owner on Jun 7, 2023. It is now read-only.

Fix snapshot transition bug #889

Merged
merged 1 commit into from
Jan 8, 2019

Conversation

laumair
Copy link
Contributor

@laumair laumair commented Jan 7, 2019

Description

Cancellation of snapshot transition during address generation lead to a possibility of attaching addresses of a different account. This PR fixes the problem.

Type of change

  • Bug fix

How Has This Been Tested?

  • Added unit test coverage
  • Manually tested on iOS (dev mode)

Checklist:

  • My code follows the style guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • For changes to mobile that include native code (including React Native modules): I have verified that both iOS and Android successfully build in both Debug and Release modes
  • For changes to shared: If applicable, I have verified that my changes are implemented correctly in desktop and mobile

Cancellation of snapshot transition during address generation lead to a possibility of attaching addresses of a different account. This commit fixes the problem.
@laumair laumair added T - Bug Type - Bug: Something isn't working C - Mobile L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this labels Jan 7, 2019
@rajivshah3 rajivshah3 merged commit ad13482 into iotaledger:develop Jan 8, 2019
@laumair laumair deleted the hotfix/snapshot-transition branch February 15, 2019 10:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C - Mobile L - Need reviews Lifecycle - Each PR must have at least two reviewers P2 - High Priority - Prefer to fix or merge this T - Bug Type - Bug: Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants