This repository has been archived by the owner on Jun 7, 2023. It is now read-only.
Mobile/iOS: Fix zoom calculation #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See react-native-camera/react-native-camera#1772 Co-authored-by: Michael Sageryd <michael@sageryd.se>
rajivshah3
added
T - Bug
rajivshah3
changed the title
cvarley100
approved these changes
Feb 6, 2019
This was referenced Feb 7, 2019
rihardsgravis
pushed a commit
that referenced
this pull request
Feb 7, 2019
* feature/realm: Mobile Release 0.4.1 (41) (#1029) New Crowdin translations [ci skip] (#1026) New Crowdin translations [ci skip] (#985) Realm data encryption (#1018) Bump webpack from 4.29.1 to 4.29.2 in /src/desktop (#1024) Bump react-dom from 16.7.0 to 16.8.0 in /src/desktop (#1022) Bump puppeteer from 1.12.1 to 1.12.2 in /src/desktop (#1019) Mobile/iOS: Fix zoom calculation (#995) Bump @babel/plugin-proposal-object-rest-spread in /src/desktop (#1015) Bump webpack from 4.29.0 to 4.29.1 in /src/desktop (#1014) Bump dart-sass from 1.16.1 to 1.17.0 in /src/desktop (#1016) Bump webpack-cli from 3.2.1 to 3.2.3 in /src/desktop (#1017) # Conflicts: # src/shared/containers/components/List.js
rihardsgravis
pushed a commit
that referenced
this pull request
Feb 11, 2019
…ation * desktop-realm-bugfixes: (107 commits) Add missing Windows required dependency Focus wallet window after initial store update Shared: Only rebuild Realm on Debian [Security] Bump extend from 3.0.1 to 3.0.2 (#1037) - Remove Realm instance init from Tray application - Keep Realm encryption key on keychain initialisation Bump react from 16.7.0 to 16.8.1 in /src/desktop (#1030) Bump fastlane from 2.115.0 to 2.116.0 in /src/mobile/ios (#1033) Bump fastlane from 2.115.0 to 2.116.0 in /src/mobile/android (#1032) Mobile Release 0.4.1 (41) (#1029) New Crowdin translations [ci skip] (#1026) New Crowdin translations [ci skip] (#985) Realm data encryption (#1018) Update Realm path for test environment - Fix Realm storage path - Add missing wallet reset triggers - Fix address component prop use - Remove failed bundle hash action Bump webpack from 4.29.1 to 4.29.2 in /src/desktop (#1024) Bump react-dom from 16.7.0 to 16.8.0 in /src/desktop (#1022) Bump puppeteer from 1.12.1 to 1.12.2 in /src/desktop (#1019) Mobile/iOS: Fix zoom calculation (#995) Bump @babel/plugin-proposal-object-rest-spread in /src/desktop (#1015) Bump webpack from 4.29.0 to 4.29.1 in /src/desktop (#1014) ...
rajivshah3
added a commit
that referenced
this pull request
Mar 15, 2019
* Mobile: Bump patch-package * Mobile/iOS: Fix zoom calculation See react-native-camera/react-native-camera#1772 Co-authored-by: Michael Sageryd <michael@sageryd.se>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes zoom calculation on iOS, preventing cases where the QR scanner zooms in too much.
Type of change
How Has This Been Tested?
Checklist:
mobilethat include native code (including React Native modules): I have verified that both iOS and Android successfully build in bothDebugandReleasemodes