-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Implement Capacitor wallet plugin binding #1646
Merged
thibault-martinez
merged 199 commits into
iotaledger:develop
from
amadeu2:feat/capacitor-iota-wallet-plugin
Mar 20, 2023
Merged
Feat: Implement Capacitor wallet plugin binding #1646
thibault-martinez
merged 199 commits into
iotaledger:develop
from
amadeu2:feat/capacitor-iota-wallet-plugin
Mar 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
thibault-martinez
previously approved these changes
Mar 20, 2023
Thoralf-M
previously approved these changes
Mar 20, 2023
rajivshah3
previously approved these changes
Mar 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! 🎉
kwek20
reviewed
Mar 20, 2023
...t/bindings/capacitorjs/android/src/main/java/org/iota/IotaWalletMobile/IotaWalletMobile.java
Show resolved
Hide resolved
kwek20
reviewed
Mar 20, 2023
...t/bindings/capacitorjs/android/src/main/java/org/iota/IotaWalletMobile/IotaWalletMobile.java
Outdated
Show resolved
Hide resolved
kwek20
reviewed
Mar 20, 2023
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
kwek20
reviewed
Mar 20, 2023
amadeu2
dismissed stale reviews from rajivshah3, Thoralf-M, and thibault-martinez
via
March 20, 2023 17:15
31be07d
Signed-off-by: Amadeo Marchioni <amadeo.marchioni@iota.org>
kwek20
approved these changes
Mar 20, 2023
thibault-martinez
approved these changes
Mar 20, 2023
Thoralf-M
approved these changes
Mar 20, 2023
rajivshah3
approved these changes
Mar 20, 2023
This was
linked to
issues
Mar 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
This PR implements the Stardust Capacitor wallet plugin for Firefly Mobile.
UPDATE: Now also includes the updates to the latest version of wallet.rs and updates
clearLiseners
implementation.The
wallet/bindings/swift
folder changes was paired with latest updates.Generated using Create Capacitor plugin:
https://github.com/ionic-team/create-capacitor-plugin
Notice that most of the code is the plugin boilerplate, the native implementation are mainly in this two files:
wallet/bindings/capacitorjs/android/src/main/java/org/iota/iotawalletmobile/IotaWalletMobile.java
wallet/bindings/capacitorjs/ios/Plugin/Plugin.swift
Also in the previous Capacitor wallet plugin the XCFramework which loads the iOS binaries was implemented here:
https://github.com/iotaledger/wallet-ios-internal
This PR implement it inside the plugin folder here:
wallet/bindings/capacitorjs/ios/WalletFramework.xcframework
with the idea to pair with Android implementation and make it easier to update.
Capacitor plugins include a PWA version in addition to the Android and iOS ones. But PWA was removed as we don't need it.
Capacitor plugin docs:
https://capacitorjs.com/docs/plugins/creating-plugins
Links to any relevant issues
fixes issue #1536 #1535 #1786 #1788
Type of change
How the change has been tested
To install the plugin in Firefly repository:
Requirements:
#more info here https://discord.com/channels/397872799483428865/930250781649690634/1085668890429902949
Tested on Linux, MacOS and Windows.
How to build Swift binding for mobile:
Change checklist
Tick the boxes that are relevant to your changes, and delete any items that are not.