refactor metrics #2611
Merged
refactor metrics #2611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dessaya
force-pushed
the
refactor-metrics
branch
3 times, most recently
from
2daadb4
to
3342cf7
Compare
dessaya
force-pushed
the
refactor-metrics
branch
from
3342cf7
to
a55391f
Compare
jorgemmsilva
approved these changes
Jun 20, 2023
Comment on lines
+23
to
+39
| messagesL1 *prometheus.CounterVec // TODO: Outdated and should be removed? | ||
| lastL1MessageTime *prometheus.GaugeVec // TODO: Outdated and should be removed? | ||
| messagesL1Chain *prometheus.CounterVec // TODO: Outdated and should be removed? | ||
| lastL1MessageTimeChain *prometheus.GaugeVec // TODO: Outdated and should be removed? | ||
|
|
||
| inMilestone *MessageMetric[*nodeclient.MilestoneInfo] // TODO: Outdated and should be removed? | ||
| inStateOutput *MessageMetric[*InStateOutput] // TODO: Outdated and should be removed? | ||
| inAliasOutput *MessageMetric[*iotago.AliasOutput] // TODO: Outdated and should be removed? | ||
| inOutput *MessageMetric[*InOutput] // TODO: Outdated and should be removed? | ||
| inOnLedgerRequest *MessageMetric[isc.OnLedgerRequest] // TODO: Outdated and should be removed? | ||
| inTxInclusionState *MessageMetric[*TxInclusionStateMsg] // TODO: Outdated and should be removed? | ||
| outPublishStateTransaction *MessageMetric[*StateTransaction] // TODO: Outdated and should be removed? | ||
| outPublishGovernanceTransaction *MessageMetric[*iotago.Transaction] // TODO: Outdated and should be removed? | ||
| outPullLatestOutput *MessageMetric[interface{}] // TODO: Outdated and should be removed? | ||
| outPullTxInclusionState *MessageMetric[iotago.TransactionID] // TODO: Outdated and should be removed? | ||
| outPullOutputByID *MessageMetric[iotago.OutputID] // TODO: Outdated and should be removed? | ||
| } |
There was a problem hiding this comment.
we should probably create an issue for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.