Fix Dependency on ESPNexUpload #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This "got lost" during previous refactoring. mDNS resolution fails for IASBlink #140
Wrapped the code into an precompiler if statement to prevent the compiler from checking the code when OTA_UPD_CHECK_NEXTION is false and the Nextion library is not included: #include "../config.h" #if OTA_UPD_CHECK_NEXTION == true ... code ... #endif
Wrapped the code into an precompiler if statement to prevent the compiler from checking the code when OTA_UPD_CHECK_NEXTION is false and the Nextion library is not included: #include "../config.h" #if OTA_UPD_CHECK_NEXTION == true ... code ... #endif
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapped the code into an precompiler if statement to prevent the compiler from checking the code when OTA_UPD_CHECK_NEXTION is false and the Nextion library is not included:
#include "../config.h"
#if OTA_UPD_CHECK_NEXTION == true
... code ...
#endif
This should fix the following issue: 2.1.0 Dependency on ESPNexUpload Library #129