Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use Address() API to simplify code #2749

Closed
dustinxie opened this issue Jul 29, 2021 · 1 comment · Fixed by #2751
Closed

use Address() API to simplify code #2749

dustinxie opened this issue Jul 29, 2021 · 1 comment · Fixed by #2751
Labels
good first issue Good for newcomers

Comments

@dustinxie
Copy link
Member

What would you like to be added:
replace

pubKey := prvKey.PublicKey()
addr, _ := address.FromBytes(pubKey.Hash())

with

addr := pubKey.Address()

Why is this needed:

  1. the latest go-pkgs added Address() API to directly output the Address object given the public key
  2. more concise code
@dustinxie dustinxie added the good first issue Good for newcomers label Jul 29, 2021
@dustinxie dustinxie mentioned this issue Jul 29, 2021
Merged
ashishsnigam pushed a commit to ashishsnigam/iotex-core-1 that referenced this issue Jul 31, 2021
@ashishedjx
use Address() API to simplify code iotexproject#2749 fixed
2773bea
ashishsnigam added a commit to ashishsnigam/iotex-core-1 that referenced this issue Jul 31, 2021
@ashishsnigam
use Address() API to simplify code iotexproject#2749 fixed
b0812c3
@ashishsnigam ashishsnigam mentioned this issue Jul 31, 2021
Merged
ashishsnigam added a commit to ashishsnigam/iotex-core-1 that referenced this issue Jul 31, 2021
@ashishsnigam
use Address() API to simplify code iotexproject#2749 fixed
0dc80b3
@ashishsnigam
Copy link
Contributor

@dustinxie Please review it.

dustinxie pushed a commit that referenced this issue Aug 23, 2021
@ashishsnigam
use Address() API to simplify code #2749 fixed (#2751)
7aa75dc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

use Address() API to simplify code #2749 fixed ashishsnigam/iotex-core-1
2 participants
@ashishsnigam @dustinxie