Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix mockgen issue #1720

Merged
merged 1 commit into from Nov 26, 2019
Merged

fix mockgen issue #1720

merged 1 commit into from Nov 26, 2019

Conversation

yutongp
Copy link
Contributor

@yutongp yutongp commented Nov 26, 2019

remove cycling dependency

@yutongp yutongp requested a review from a team as a code owner November 26, 2019 21:16
@codecov
Copy link

codecov bot commented Nov 26, 2019

Codecov Report

Merging #1720 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1720      +/-   ##
==========================================
- Coverage   55.19%   55.18%   -0.02%     
==========================================
  Files         155      155              
  Lines       13494    13494              
==========================================
- Hits         7448     7446       -2     
- Misses       5071     5072       +1     
- Partials      975      976       +1
Impacted Files Coverage Δ
db/trie/extensionnode.go 57.62% <0%> (-1.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 503b58e...a592a01. Read the comment docs.

@yutongp yutongp merged commit fef30b3 into master Nov 26, 2019
@yutongp yutongp deleted the yutong/fix_mock branch November 26, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants