systemlog indexer and api #1960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frankonly
force-pushed
the
systemlog
branch
3 times, most recently
from
c3fcdf6
to
5b1408b
Compare
Codecov Report
@@ Coverage Diff @@
## master #1960 +/- ##
==========================================
+ Coverage 58.13% 58.32% +0.19%
==========================================
Files 186 185 -1
Lines 16143 16089 -54
==========================================
Hits 9384 9384
+ Misses 5592 5518 -74
- Partials 1167 1187 +20
Continue to review full report at Codecov.
|
CoderZhi
reviewed
Mar 9, 2020
chainservice/chainservice.go
Outdated
| } else { | ||
| dao = blockdao.NewBlockDAO(kvStore, nil, cfg.Chain.CompressBlock, cfg.DB) | ||
| } | ||
| dao := blockdao.NewBlockDAO(kvStore, indexers, cfg.Chain.CompressBlock, cfg.DB) |
There was a problem hiding this comment.
indexers are appended to blockdao in sync mode. In async mode, we need to add the indexers as subscriber. So you need to revert this change.
There was a problem hiding this comment.
I handle this at line 163
if !cfg.Chain.EnableAsyncIndexWrite {
indexers = append(indexers, indexer)
}
There was a problem hiding this comment.
Or we need to make systemlog indexer as subsrciber?
Frankonly
force-pushed
the
systemlog
branch
2 times, most recently
from
70ee38e
to
ae13563
Compare
CoderZhi
approved these changes
Mar 11, 2020
Comment on lines
185
to
+186
| var dao blockdao.BlockDAO | ||
| if gateway && !cfg.Chain.EnableAsyncIndexWrite { | ||
| dao = blockdao.NewBlockDAO(kvStore, []blockdao.BlockIndexer{indexer}, cfg.Chain.CompressBlock, cfg.DB) | ||
| } else { | ||
| dao = blockdao.NewBlockDAO(kvStore, nil, cfg.Chain.CompressBlock, cfg.DB) | ||
| } | ||
| dao = blockdao.NewBlockDAO(kvStore, indexers, cfg.Chain.CompressBlock, cfg.DB) |
|
It is better to have system log indexer and the action indexer sharing the same config, EnableAsyncIndexing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.