move block sync request limit #3231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3231 +/- ##
==========================================
- Coverage 74.96% 74.95% -0.01%
==========================================
Files 228 228
Lines 21355 21353 -2
==========================================
- Hits 16008 16006 -2
- Misses 4477 4478 +1
+ Partials 870 869 -1
Continue to review full report at Codecov.
|
Liuhaai
reviewed
Mar 28, 2022
| d.syncChanLock.Lock() | ||
| defer d.syncChanLock.Unlock() | ||
| last, ok := d.peerLastSync[peerID] |
There was a problem hiding this comment.
I think reserving the subfunc is more readable.
if !d.checkSyncPermission(peer.ID.Pretty()) {
return
}
There was a problem hiding this comment.
do you consider this style issue as a blocker of this PR?
Liuhaai
approved these changes
Mar 30, 2022
dustinxie
approved these changes
Mar 30, 2022
CoderZhi
force-pushed
the
reject_block_sync_request
branch
from
a36d874
to
687b779
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move block sync request limit position from consumer side to producer size to prevent flooding request from one neighbor.
Fixes #3228
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
make minicluster
Test Configuration:
Checklist: