New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[state] Return err if receipt is nil #3759
Conversation
nil
if receipt is nil
Codecov Report
@@ Coverage Diff @@
## master #3759 +/- ##
==========================================
+ Coverage 74.47% 75.15% +0.68%
==========================================
Files 269 299 +30
Lines 23925 25201 +1276
==========================================
+ Hits 17818 18940 +1122
- Misses 5174 5287 +113
- Partials 933 974 +41
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -36,7 +36,7 @@ var ( | |||
) | |||
|
|||
func init() { | |||
initTestDefaultConfig() | |||
initTestDefaultConfig(&Default) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think we should remove this?
func TestDefault() Genesis { | ||
ge := defaultConfig() | ||
initTestDefaultConfig(&ge) | ||
return ge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make test
, and use TestDefault()
wherever the test fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it can be changed in another pr. This pr is to fix receipt issue.
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
* fix issue 3555
Description
Fixes #(issue)
fix #3555
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: