Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[context] remove FixRewardErroCheckPosition flag #3851

Merged
merged 1 commit into from Apr 25, 2023

Conversation

dustinxie
Copy link
Member

Description

for safety, the change is protected by hard-fork. Now that the hard-fork has passed, can remove the gating check

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #3851 (8eb8e95) into master (e1f0636) will increase coverage by 0.07%.
The diff coverage is 71.26%.

❗ Current head 8eb8e95 differs from pull request most recent head d70d544. Consider uploading reports for the commit d70d544 to get more accurate results

@@            Coverage Diff             @@
##           master    #3851      +/-   ##
==========================================
+ Coverage   75.38%   75.45%   +0.07%     
==========================================
  Files         303      303              
  Lines       25923    26033     +110     
==========================================
+ Hits        19541    19643     +102     
- Misses       5360     5370      +10     
+ Partials     1022     1020       -2     
Impacted Files Coverage Δ
api/web3server_marshal.go 93.21% <ø> (ø)
api/web3server_utils.go 69.20% <16.66%> (-3.67%) ⬇️
state/factory/factory.go 80.20% <33.33%> (+0.86%) ⬆️
state/factory/statedb.go 81.81% <33.33%> (+1.08%) ⬆️
api/serverV2.go 86.95% <50.00%> (ø)
state/factory/workingset.go 71.42% <68.75%> (ø)
api/web3server.go 81.41% <87.50%> (+2.74%) ⬆️
api/coreservice.go 68.09% <88.23%> (+0.74%) ⬆️
action/protocol/context.go 67.17% <100.00%> (ø)
action/protocol/rewarding/reward.go 90.07% <100.00%> (+0.60%) ⬆️
... and 1 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dustinxie dustinxie merged commit f60f636 into iotexproject:master Apr 25, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants