Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

contract indexer handle BucketExpanded event #3881

Merged
merged 7 commits into from Jun 8, 2023

Conversation

envestcc
Copy link
Member

@envestcc envestcc commented Jun 6, 2023

Description

The contract indexer needs to be adapted to accommodate the newly added BucketExpanded event in the contract.

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@envestcc envestcc requested review from CoderZhi, dustinxie, Liuhaai and a team as code owners June 6, 2023 13:58
@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #3881 (1df6ffc) into master (e1f0636) will increase coverage by 0.19%.
The diff coverage is 66.02%.

❗ Current head 1df6ffc differs from pull request most recent head ead5608. Consider uploading reports for the commit ead5608 to get more accurate results

@@            Coverage Diff             @@
##           master    #3881      +/-   ##
==========================================
+ Coverage   75.38%   75.57%   +0.19%     
==========================================
  Files         303      325      +22     
  Lines       25923    27566    +1643     
==========================================
+ Hits        19541    20832    +1291     
- Misses       5360     5663     +303     
- Partials     1022     1071      +49     
Impacted Files Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) ⬇️
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
...tion/protocol/staking/contractstake_bucket_type.go 0.00% <0.00%> (ø)
api/web3server_marshal.go 93.21% <ø> (ø)
blockchain/config.go 74.54% <ø> (ø)
blockindex/contractstaking/dummy_indexer.go 0.00% <0.00%> (ø)
blockindex/sgd_indexer.go 2.45% <2.45%> (ø)
action/protocol/staking/contractstake_indexer.go 14.28% <14.28%> (ø)
... and 38 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

SystemStakingContractAddress: "io1uw3gvmhrjz5mwxpd966wxxt6fn5uuvwfpynrwj",
SystemStakingContractHeight: 20386536,
SystemStakingContractAddress: "io1224slckr49ryfhsg3z3m484pgsm89esl2nd4jh",
SystemStakingContractHeight: 20645456,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

revert this, testnet params will be added in config/genesis
once we deploy the contract on mainnet, file a PR to update here

@sonarcloud
Copy link

sonarcloud bot commented Jun 8, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
48.1% 48.1% Duplication

@dustinxie dustinxie merged commit 0eddba5 into iotexproject:master Jun 8, 2023
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants