build contract staking indexer only when staking protocol enabled #3886
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
Codecov Report
@@ Coverage Diff @@
## master #3886 +/- ##
==========================================
+ Coverage 75.38% 76.05% +0.67%
==========================================
Files 303 327 +24
Lines 25923 27855 +1932
==========================================
+ Hits 19541 21186 +1645
- Misses 5360 5578 +218
- Partials 1022 1091 +69
... and 5 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
| @@ -298,6 +298,9 @@ func (builder *Builder) buildSGDRegistry(forTest bool) error { | |||
| } | |||
|
|
|||
| func (builder *Builder) buildContractStakingIndexer(forTest bool) error { | |||
| if !builder.cfg.Chain.EnableStakingProtocol { | |||
There was a problem hiding this comment.
will contractStakingIndexer be nil when enabled?
There was a problem hiding this comment.
in theory it could be, if cfg.Genesis.SystemStakingContractAddress == "" in the config
in prod, the contract address is valid, and contractStakingIndexer will be created
There was a problem hiding this comment.
should ContractStakingIndexer be built when cfg.Genesis.SystemStakingContractAddress == ""
There was a problem hiding this comment.
no, in that case, means SystemStaking (IIP-13) is not enabled on the chain, no need to build the indexer
|
Kudos, SonarCloud Quality Gate passed!
|
Description
Currently, the usage of the contract stake indexer is limited to the staking module. Therefore, if the staking protocol is not enabled, there is no need to create the indexer.
Fixes #(issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Checklist: