Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ioctl] Add INS register cmd #3903

Merged
merged 7 commits into from Jul 18, 2023
Merged

[ioctl] Add INS register cmd #3903

merged 7 commits into from Jul 18, 2023

Conversation

ququzone
Copy link
Contributor

Description

Add register cmd for ioctl

Fixes #(issue)

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ququzone ququzone changed the title INS cli [ioctk] Add INS register cmd Jul 12, 2023
@ququzone ququzone changed the title [ioctk] Add INS register cmd [ioctl] Add INS register cmd Jul 12, 2023
@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Merging #3903 (5838dc3) into master (e1f0636) will increase coverage by 0.75%.
The diff coverage is 74.49%.

❗ Current head 5838dc3 differs from pull request most recent head 756b152. Consider uploading reports for the commit 756b152 to get more accurate results

@@            Coverage Diff             @@
##           master    #3903      +/-   ##
==========================================
+ Coverage   75.38%   76.13%   +0.75%     
==========================================
  Files         303      326      +23     
  Lines       25923    27808    +1885     
==========================================
+ Hits        19541    21171    +1630     
- Misses       5360     5546     +186     
- Partials     1022     1091      +69     
Impacted Files Coverage Δ
action/protocol/execution/evm/evm.go 43.52% <0.00%> (-2.95%) ⬇️
action/protocol/execution/evm/evmstatedbadapter.go 66.77% <ø> (ø)
action/protocol/poll/consortium.go 0.00% <0.00%> (ø)
action/protocol/poll/staking_committee.go 43.85% <0.00%> (ø)
...tion/protocol/staking/contractstake_bucket_type.go 0.00% <0.00%> (ø)
api/grpcserver.go 86.40% <0.00%> (ø)
api/loglistener.go 25.00% <0.00%> (ø)
api/web3server_marshal.go 93.21% <ø> (ø)
api/websocket.go 5.17% <0.00%> (ø)
blockchain/config.go 74.54% <ø> (ø)
... and 50 more

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

ioctl/cmd/ins/ins.go Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ququzone ququzone merged commit 796918a into master Jul 18, 2023
4 checks passed
@ququzone ququzone deleted the ins-cli branch July 18, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants