Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): add web3server unit test #4131

Merged
merged 3 commits into from Feb 6, 2024
Merged

feat(test): add web3server unit test #4131

merged 3 commits into from Feb 6, 2024

Conversation

hunshenshi
Copy link
Member

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #4116

Type of change

Please delete options that are not relevant.

  • [] Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • [] Code refactor or improvement
  • [] Breaking change (fix or feature that would cause a new or changed behavior of existing functionality)
  • [] This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • [] make test
  • [] fullsync
  • [] Other test (please specify)

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • [] My code follows the style guidelines of this project
  • [] I have performed a self-review of my code
  • [] I have commented my code, particularly in hard-to-understand areas
  • [] I have made corresponding changes to the documentation
  • [] My changes generate no new warnings
  • [] I have added tests that prove my fix is effective or that my feature works
  • [] New and existing unit tests pass locally with my changes
  • [] Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Feb 5, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 556 lines in your changes are missing coverage. Please review.

Comparison is base (e1f0636) 75.38% compared to head (8c50bf0) 76.29%.
Report is 169 commits behind head on master.

Files Patch % Lines
action/protocol/staking/staking_statereader.go 69.76% 35 Missing and 17 partials ⚠️
action/protocol/execution/evm/evm.go 48.38% 47 Missing and 1 partial ⚠️
api/coreservice.go 63.24% 37 Missing and 6 partials ⚠️
action/candidate_endorsement.go 0.00% 31 Missing ⚠️
api/web3server.go 80.50% 29 Missing and 2 partials ⚠️
action/protocol/staking/protocol.go 45.09% 28 Missing ⚠️
action/candidate_activate.go 0.00% 25 Missing ⚠️
...tion/protocol/staking/contractstake_bucket_type.go 0.00% 24 Missing ⚠️
action/protocol/rewarding/fund.go 23.07% 19 Missing and 1 partial ⚠️
api/websocket.go 0.00% 20 Missing ⚠️
... and 44 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4131      +/-   ##
==========================================
+ Coverage   75.38%   76.29%   +0.91%     
==========================================
  Files         303      339      +36     
  Lines       25923    28871    +2948     
==========================================
+ Hits        19541    22027    +2486     
- Misses       5360     5738     +378     
- Partials     1022     1106      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoderZhi
Copy link
Collaborator

CoderZhi commented Feb 5, 2024

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

@hunshenshi

Copy link

sonarcloud bot commented Feb 6, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

3 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@hunshenshi hunshenshi merged commit d4d6b6b into master Feb 6, 2024
3 of 5 checks passed
@hunshenshi hunshenshi deleted the pr-41116 branch February 6, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add unit tests for api/web3server.go
4 participants